Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/510340/?format=api
{ "id": 510340, "url": "http://patchwork.ozlabs.org/api/patches/510340/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440462444-32504-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1440462444-32504-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-08-25T00:27:24", "name": "[next-queue,v2] fm10k: do not assume VF always has 1 queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "35a389c79548962f0b2fdd39a0924ae477d33434", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1440462444-32504-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/510340/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/510340/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 316AB140271\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 25 Aug 2015 10:27:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3B8F5A44DA;\n\tTue, 25 Aug 2015 00:27:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UF4wYA2iEFfw; Tue, 25 Aug 2015 00:27:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AF75BA44C9;\n\tTue, 25 Aug 2015 00:27:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E47161BFF41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Aug 2015 00:27:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DD59F938FF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Aug 2015 00:27:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l4rzfOK4uiNp for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Aug 2015 00:27:27 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4C0FF8ABA0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Aug 2015 00:27:27 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 24 Aug 2015 17:27:27 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.3.123])\n\tby orsmga001.jf.intel.com with ESMTP; 24 Aug 2015 17:27:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,742,1432623600\"; d=\"scan'208\";a=\"754707688\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 24 Aug 2015 17:27:24 -0700", "Message-Id": "<1440462444-32504-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.5.0.280.g4aaba03", "Subject": "[Intel-wired-lan] [next-queue v2] fm10k: do not assume VF always\n\thas 1 queue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "It is possible that the PF has not yet assigned resources to the VF.\nAlthough rare, this could result in the VF attempting to read queues it\ndoes not own and result in FUM or THI faults in the PF. To prevent this,\ncheck queue 0 before we continue in init_hw_vf.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_type.h | 1 +\n drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 7 ++++++-\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_type.h b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\nindex 318a212f0a78..35afd711d144 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n@@ -77,6 +77,7 @@ struct fm10k_hw;\n #define FM10K_PCIE_SRIOV_CTRL_VFARI\t\t0x10\n \n #define FM10K_ERR_PARAM\t\t\t\t-2\n+#define FM10K_ERR_NO_RESOURCES\t\t\t-3\n #define FM10K_ERR_REQUESTS_PENDING\t\t-4\n #define FM10K_ERR_RESET_REQUESTED\t\t-5\n #define FM10K_ERR_DMA_PENDING\t\t\t-6\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\nindex 36c8b0aa08fd..3a18ef1cc017 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n@@ -103,7 +103,12 @@ static s32 fm10k_init_hw_vf(struct fm10k_hw *hw)\n \ts32 err;\n \tu16 i;\n \n-\t/* assume we always have at least 1 queue */\n+\t/* verify we have at least 1 queue */\n+\tif (!~fm10k_read_reg(hw, FM10K_TXQCTL(0)) ||\n+\t !~fm10k_read_reg(hw, FM10K_RXQCTL(0)))\n+\t\treturn FM10K_ERR_NO_RESOURCES;\n+\n+\t/* determine how many queues we have */\n \tfor (i = 1; tqdloc0 && (i < FM10K_MAX_QUEUES_POOL); i++) {\n \t\t/* verify the Descriptor cache offsets are increasing */\n \t\ttqdloc = ~fm10k_read_reg(hw, FM10K_TQDLOC(i));\n", "prefixes": [ "next-queue", "v2" ] }