Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/507250/?format=api
{ "id": 507250, "url": "http://patchwork.ozlabs.org/api/patches/507250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150814015431.3815.82403.stgit@jbrandeb-hsm1.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150814015431.3815.82403.stgit@jbrandeb-hsm1.jf.intel.com>", "list_archive_url": null, "date": "2015-08-14T01:54:31", "name": "[net-next,2/2] i40e: fix 32 bit build warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d92f1d5f4b21a89eebd28d390fd550755d1b545a", "submitter": { "id": 189, "url": "http://patchwork.ozlabs.org/api/people/189/?format=api", "name": "Jesse Brandeburg", "email": "jesse.brandeburg@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150814015431.3815.82403.stgit@jbrandeb-hsm1.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/507250/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/507250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id B60BD1401E7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Aug 2015 11:54:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 147F5920D9;\n\tFri, 14 Aug 2015 01:54:56 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2fjI0u5TLqjt; Fri, 14 Aug 2015 01:54:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 779148FF28;\n\tFri, 14 Aug 2015 01:54:55 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id D3F1D1BFED7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Aug 2015 01:54:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C1B5333FE1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Aug 2015 01:54:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DzGie4jHMrza for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Aug 2015 01:54:53 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTP id 77A4233F09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Aug 2015 01:54:53 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 13 Aug 2015 18:54:31 -0700", "from jbrandeb-hsm1.jf.intel.com ([134.134.3.89])\n\tby orsmga003.jf.intel.com with ESMTP; 13 Aug 2015 18:54:31 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,674,1432623600\"; d=\"scan'208\";a=\"625219132\"", "From": "Jesse Brandeburg <jesse.brandeburg@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 13 Aug 2015 18:54:31 -0700", "Message-ID": "<20150814015431.3815.82403.stgit@jbrandeb-hsm1.jf.intel.com>", "In-Reply-To": "<20150814015426.3815.89257.stgit@jbrandeb-hsm1.jf.intel.com>", "References": "<20150814015426.3815.89257.stgit@jbrandeb-hsm1.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next PATCH 2/2] i40e: fix 32 bit build\n\twarnings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Sparse found some issues with 32 bit compilation, which probably should\nat least work without warning. Not only that, but the code was wrong.\nThanks sparse!!\n\nAnd thanks to the kbuild robot zero day testing for finding this issue.\n\n$ make ARCH=i386 M=drivers/net/ethernet/intel/i40e C=2 CF=\"-D__CHECK_ENDIAN__\"\n CHECK drivers/net/ethernet/intel/i40e/i40e_main.c\n include/linux/etherdevice.h:79:32: warning: restricted __be16 degrades to integer\n drivers/net/ethernet/intel/i40e/i40e_main.c:7565:17: warning: shift too big (32) for type unsigned long\n drivers/net/ethernet/intel/i40e/i40e_main.c:7565:17: warning: shift too big (42) for type unsigned long\n drivers/net/ethernet/intel/i40e/i40e_main.c:7565:17: warning: shift too big (39) for type unsigned long\n drivers/net/ethernet/intel/i40e/i40e_main.c:7565:17: warning: shift too big (40) for type unsigned long\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nReported-by: kbuild test robot <fengguang.wu@intel.com>\nCC: kbuild-all@01.org\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 5 -----\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 12 ++++++------\n 2 files changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 80c354c..6833717 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -442,9 +442,6 @@ static i40e_status i40e_aq_get_set_rss_lut(struct i40e_hw *hw,\n \t\t\t\t\tI40E_AQC_SET_RSS_LUT_TABLE_TYPE_SHIFT) &\n \t\t\t\t\tI40E_AQC_SET_RSS_LUT_TABLE_TYPE_MASK));\n \n-\tcmd_resp->addr_high = cpu_to_le32(high_16_bits((u64)lut));\n-\tcmd_resp->addr_low = cpu_to_le32(lower_32_bits((u64)lut));\n-\n \tstatus = i40e_asq_send_command(hw, &desc, lut, lut_size, NULL);\n \n \treturn status;\n@@ -519,8 +516,6 @@ static i40e_status i40e_aq_get_set_rss_key(struct i40e_hw *hw,\n \t\t\t\t\t I40E_AQC_SET_RSS_KEY_VSI_ID_SHIFT) &\n \t\t\t\t\t I40E_AQC_SET_RSS_KEY_VSI_ID_MASK));\n \tcmd_resp->vsi_id |= cpu_to_le16((u16)I40E_AQC_SET_RSS_KEY_VSI_VALID);\n-\tcmd_resp->addr_high = cpu_to_le32(high_16_bits((u64)key));\n-\tcmd_resp->addr_low = cpu_to_le32(lower_32_bits((u64)key));\n \n \tstatus = i40e_asq_send_command(hw, &desc, key, key_size, NULL);\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex f1385a1..a992cb8f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -79,12 +79,12 @@ enum i40e_dyn_idx_t {\n \tBIT_ULL(I40E_FILTER_PCTYPE_L2_PAYLOAD))\n \n #define I40E_DEFAULT_RSS_HENA_EXPANDED (I40E_DEFAULT_RSS_HENA | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK) | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP) | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK) | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP) | \\\n-\tBIT(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP))\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK) | \\\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) | \\\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP) | \\\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK) | \\\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP) | \\\n+\tBIT_ULL(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP))\n \n #define i40e_pf_get_default_rss_hena(pf) \\\n \t(((pf)->flags & I40E_FLAG_MULTIPLE_TCP_UDP_RSS_PCTYPE) ? \\\n", "prefixes": [ "net-next", "2/2" ] }