Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/505274/?format=api
{ "id": 505274, "url": "http://patchwork.ozlabs.org/api/patches/505274/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150808002714.23033.34530.stgit@htfujina-fc.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150808002714.23033.34530.stgit@htfujina-fc.jf.intel.com>", "list_archive_url": null, "date": "2015-08-08T00:27:39", "name": "[V2] igb: make sure SR-IOV init uses the right number of queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "89b767a55c61d817cb3fb469caf4593b463038a0", "submitter": { "id": 29211, "url": "http://patchwork.ozlabs.org/api/people/29211/?format=api", "name": "Fujinaka, Todd", "email": "todd.fujinaka@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150808002714.23033.34530.stgit@htfujina-fc.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/505274/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/505274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id EA878140284\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 8 Aug 2015 10:27:42 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2C379A33BC;\n\tSat, 8 Aug 2015 00:27:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Tc6Gy2U4tQHQ; Sat, 8 Aug 2015 00:27:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5CA2AA33AA;\n\tSat, 8 Aug 2015 00:27:40 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id EEDBC1C142D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 8 Aug 2015 00:27:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E6D9790957\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 8 Aug 2015 00:27:38 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pnONvE5UR+Xt for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 8 Aug 2015 00:27:38 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3695990952\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 8 Aug 2015 00:27:38 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 07 Aug 2015 17:27:39 -0700", "from htfujina-fc.jf.intel.com ([134.134.145.125])\n\tby orsmga002.jf.intel.com with ESMTP; 07 Aug 2015 17:27:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,632,1432623600\"; d=\"scan'208\";a=\"780027426\"", "From": "Todd Fujinaka <todd.fujinaka@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 07 Aug 2015 17:27:39 -0700", "Message-ID": "<20150808002714.23033.34530.stgit@htfujina-fc.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH V2] igb: make sure SR-IOV init uses the\n\tright number of queues", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Recent changes to igb_probe_vfs() could lead to the PF holding onto all\nof the queues. Reorder igb_probe_vfs() to be before\ngb_init_queue_configuration() and add some more error checking.\n\nSigned-off-by: Todd Fujinaka <todd.fujinaka@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 338d146..1362f7b 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -179,6 +179,8 @@ static void igb_check_vf_rate_limit(struct igb_adapter *);\n #ifdef CONFIG_PCI_IOV\n static int igb_vf_configure(struct igb_adapter *adapter, int vf);\n static int igb_pci_enable_sriov(struct pci_dev *dev, int num_vfs);\n+static int igb_disable_sriov(struct pci_dev *dev);\n+static int igb_pci_disable_sriov(struct pci_dev *dev);\n #endif\n \n #ifdef CONFIG_PM\n@@ -2647,6 +2649,9 @@ err_eeprom:\n err_sw_init:\n \tkfree(adapter->shadow_vfta);\n \tigb_clear_interrupt_scheme(adapter);\n+#ifdef CONFIG_PCI_IOV\n+\tigb_disable_sriov(pdev);\n+#endif\n \tpci_iounmap(pdev, hw->hw_addr);\n err_ioremap:\n \tfree_netdev(netdev);\n@@ -2969,6 +2974,8 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \t}\n #endif /* CONFIG_PCI_IOV */\n \n+\tigb_probe_vfs(adapter);\n+\n \tigb_init_queue_configuration(adapter);\n \n \t/* Setup and initialize a copy of the hw vlan table array */\n@@ -2981,8 +2988,6 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \t\treturn -ENOMEM;\n \t}\n \n-\tigb_probe_vfs(adapter);\n-\n \t/* Explicitly disable IRQ since the NIC can be in any state. */\n \tigb_irq_disable(adapter);\n \n", "prefixes": [ "V2" ] }