Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/504593/?format=api
{ "id": 504593, "url": "http://patchwork.ozlabs.org/api/patches/504593/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438846337-6164-1-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1438846337-6164-1-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2015-08-06T07:32:17", "name": "igbvf: clear buffer_info->dma after dma_unmap_single()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f030331c643e53c0ee4ab12006f1f4a5070306fb", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438846337-6164-1-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/504593/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/504593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id E7CD814010F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Aug 2015 17:32:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 11CE3A339E;\n\tThu, 6 Aug 2015 07:32:36 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 45f7KJrnEzRm; Thu, 6 Aug 2015 07:32:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CEB75A338B;\n\tThu, 6 Aug 2015 07:32:33 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8D4EC1BFA21\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Aug 2015 07:32:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 869AC31B1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Aug 2015 07:32:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qPjYgB-0G9sQ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Aug 2015 07:32:30 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CE1722EDA1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Aug 2015 07:32:30 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 982B3345B35;\n\tThu, 6 Aug 2015 07:32:29 +0000 (UTC)", "from w541.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t767WRqU001660; Thu, 6 Aug 2015 03:32:28 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 6 Aug 2015 09:32:17 +0200", "Message-Id": "<1438846337-6164-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH] igbvf: clear buffer_info->dma after\n\tdma_unmap_single()", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver doesn't clear buffer_info->dma after calling\ndma_unmap_single() in all cases. This has been discovered by changing\nthe mtu twice, which caused the following backtrace.\n\n[ 68.569280] WARNING: CPU: 2 PID: 1860 at drivers/iommu/intel-iommu.c:3517 intel_unmap+0x20c/0x220()\n[ 68.579392] Driver unmaps unmatched page at PFN fffc2a40\n[ 68.585322] Modules linked in: igbvf ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat kvm_intel kvm igb megs\n[ 68.599163] CPU: 2 PID: 1860 Comm: ifconfig Not tainted 4.2.0-rc4+ #147\n[ 68.606543] Hardware name: IBM -[546025Z]-/00Y7630, BIOS -[VVE134TUS-1.51]- 10/17/2013\n[ 68.615473] 0000000000000dbd ffff88046441bb08 ffffffff81a5ad0b ffffffff81e2f9ea\n[ 68.623775] ffff88046441bb58 ffff88046441bb48 ffffffff81056b55 ffff88047fc583c0\n[ 68.632075] 0000000000000000 ffff880469a8e600 00000000fffc2a40 ffff880465b32098\n[ 68.640375] Call Trace:\n[ 68.643109] [<ffffffff81a5ad0b>] dump_stack+0x48/0x5d\n[ 68.648844] [<ffffffff81056b55>] warn_slowpath_common+0x95/0xe0\n[ 68.655549] [<ffffffff81056c56>] warn_slowpath_fmt+0x46/0x70\n[ 68.661960] [<ffffffff8158a614>] ? find_iova+0x54/0x90\n[ 68.667791] [<ffffffff815988dc>] intel_unmap+0x20c/0x220\n[ 68.673815] [<ffffffff8159891e>] intel_unmap_page+0xe/0x10\n[ 68.680038] [<ffffffffa0067536>] igbvf_clean_rx_ring+0x96/0x370 [igbvf]\n[ 68.687516] [<ffffffffa0067915>] igbvf_down+0x105/0x110 [igbvf]\n[ 68.694219] [<ffffffffa0067beb>] igbvf_change_mtu+0x16b/0x180 [igbvf]\n[...]\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/igbvf/netdev.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c\nindex 95af14e..686fa71 100644\n--- a/drivers/net/ethernet/intel/igbvf/netdev.c\n+++ b/drivers/net/ethernet/intel/igbvf/netdev.c\n@@ -319,6 +319,7 @@ static bool igbvf_clean_rx_irq(struct igbvf_adapter *adapter,\n \t\t\tdma_unmap_single(&pdev->dev, buffer_info->dma,\n \t\t\t\t\t adapter->rx_ps_hdr_size,\n \t\t\t\t\t DMA_FROM_DEVICE);\n+\t\t\tbuffer_info->dma = 0;\n \t\t\tskb_put(skb, hlen);\n \t\t}\n \n", "prefixes": [] }