Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/504430/?format=api
{ "id": 504430, "url": "http://patchwork.ozlabs.org/api/patches/504430/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150805225237.GA31471@electric-eye.fr.zoreil.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150805225237.GA31471@electric-eye.fr.zoreil.com>", "list_archive_url": null, "date": "2015-08-05T22:52:37", "name": "[1/1,net-next] e1000: remove dead e1000_init_eeprom_params calls.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0e3c434050d01192d9f6a439514259c8d14f6339", "submitter": { "id": 513, "url": "http://patchwork.ozlabs.org/api/people/513/?format=api", "name": "Francois Romieu", "email": "romieu@fr.zoreil.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150805225237.GA31471@electric-eye.fr.zoreil.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/504430/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/504430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 46E341402B8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Aug 2015 09:18:41 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1F333A3B40;\n\tWed, 5 Aug 2015 23:18:41 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Q3N6LqdjpVgs; Wed, 5 Aug 2015 23:18:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4BB83A3B27;\n\tWed, 5 Aug 2015 23:18:39 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C83981CE4F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 23:00:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C1F9E91ED8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 23:00:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CjeEd5+HyBUx for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 23:00:24 +0000 (UTC)", "from violet.fr.zoreil.com (violet.fr.zoreil.com [92.243.8.30])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 084AE91E47\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 23:00:23 +0000 (UTC)", "from violet.fr.zoreil.com (localhost [127.0.0.1])\n\tby violet.fr.zoreil.com (8.14.9/8.14.5) with ESMTP id t75MqcR3031778; \n\tThu, 6 Aug 2015 00:52:38 +0200", "(from romieu@localhost)\n\tby violet.fr.zoreil.com (8.14.9/8.14.5/Submit) id t75MqbQC031777;\n\tThu, 6 Aug 2015 00:52:37 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:07:24 by SQLgrey-1.7.6", "Date": "Thu, 6 Aug 2015 00:52:37 +0200", "From": "Francois Romieu <romieu@fr.zoreil.com>", "To": "intel-wired-lan@lists.osuosl.org", "Message-ID": "<20150805225237.GA31471@electric-eye.fr.zoreil.com>", "MIME-Version": "1.0", "Content-Disposition": "inline", "X-Organisation": "Land of Sunshine Inc.", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Mailman-Approved-At": "Wed, 05 Aug 2015 23:18:38 +0000", "Subject": "[Intel-wired-lan] [PATCH 1/1 net-next] e1000: remove dead\n\te1000_init_eeprom_params calls.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The device probe method e1000_probe calls e1000_init_eeprom_params\nitself so there's no reason to call it again from e1000_do_write_eeprom\nor e1000_do_read_eeprom.\n\nThe sentence above assumes that e1000_init_eeprom_params is effective.\ne1000_init_eeprom_params depends mostly on hw->mac_type and e1000_probe\nbails out early if it can't set mac_type (see e1000_init_hw_struct, then\ne1000_set_mac_type), qed.\n\nBtw, if effective, the removed paths would had been deadlock prone when\ne1000_eeprom_spi was set:\n-> e1000_write_eeprom (takes e1000_eeprom_lock)\n -> e1000_do_write_eeprom\n -> e1000_init_eeprom_params\n -> e1000_read_eeprom (takes e1000_eeprom_lock)\n\n(same narrative with e1000_read_eeprom -> e1000_do_read_eeprom etc.)\n\nAs a final note, the candidate deadlock above can't happen in e1000_probe\ndue to the way eeprom->word_size is set / tested.\n\nSigned-off-by: Francois Romieu <romieu@fr.zoreil.com>\n---\n\n Patch against davem's net-next as of 9dc20a649609c95ce7c5ac4282656ba627b67d49.\n\n I noticed these calls while looking at Joern Engel's e1000 eeprom read/write\n scheduler friendly patch.\n\n drivers/net/ethernet/intel/e1000/e1000_hw.c | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c\nindex 45c8c864..b1af0d6 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c\n@@ -3900,10 +3900,6 @@ static s32 e1000_do_read_eeprom(struct e1000_hw *hw, u16 offset, u16 words,\n \t\treturn E1000_SUCCESS;\n \t}\n \n-\t/* If eeprom is not yet detected, do so now */\n-\tif (eeprom->word_size == 0)\n-\t\te1000_init_eeprom_params(hw);\n-\n \t/* A check for invalid values: offset too large, too many words, and\n \t * not enough words.\n \t */\n@@ -4074,10 +4070,6 @@ static s32 e1000_do_write_eeprom(struct e1000_hw *hw, u16 offset, u16 words,\n \t\treturn E1000_SUCCESS;\n \t}\n \n-\t/* If eeprom is not yet detected, do so now */\n-\tif (eeprom->word_size == 0)\n-\t\te1000_init_eeprom_params(hw);\n-\n \t/* A check for invalid values: offset too large, too many words, and\n \t * not enough words.\n \t */\n", "prefixes": [ "1/1", "net-next" ] }