Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/504031/?format=api
{ "id": 504031, "url": "http://patchwork.ozlabs.org/api/patches/504031/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438783516-13283-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1438783516-13283-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2015-08-05T14:05:16", "name": "igb: Fix a memory leak in igb_probe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "21935d266376a14c18fb5a2f8a9d6137de46366e", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438783516-13283-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/504031/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/504031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 817DA1402B9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Aug 2015 00:21:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B7F5433648;\n\tWed, 5 Aug 2015 14:20:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 10PRY4v6cYDt; Wed, 5 Aug 2015 14:20:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1DECD238F7;\n\tWed, 5 Aug 2015 14:20:59 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E28521C2D19\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 14:20:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DB92233586\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 14:20:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RBNy2j7TjlAV for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 14:20:56 +0000 (UTC)", "from m12-18.163.com (m12-18.163.com [220.181.12.18])\n\tby silver.osuosl.org (Postfix) with ESMTP id E9E65238F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Aug 2015 14:20:55 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [166.111.70.58])\n\tby smtp14 (Coremail) with SMTP id EsCowEAJwEMcGMJVNiyCAg--.20474S2;\n\tWed, 05 Aug 2015 22:05:22 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=VGZ3Wr2P;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:15:25 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=mzhtRCCb4uP+eNbl3Y\n\tznfD1T/pcYR/izfnqqriKXLRU=; b=VGZ3Wr2PLhyK2wTdbFSTRpsTuqqEvDR0Ug\n\tVNZadjd9VC/97nma8XR0DvB/aa9gT09FAQzpcaWKdsNuZn3vgv4mmh5YDbb1Wri/\n\tXbJHkC8xsNS0HZAuKPz2NIuq6rGQzCjMylDuSDscLzKOHlCZqmMMN0V9ovMUxSEC\n\ts7pvvWuPY=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tjesse.brandeburg@intel.com", "Date": "Wed, 5 Aug 2015 22:05:16 +0800", "Message-Id": "<1438783516-13283-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "EsCowEAJwEMcGMJVNiyCAg--.20474S2", "X-Coremail-Antispam": "1Uf129KBjvdXoWrZrWxXr4fJFW3Zr45XF4fXwb_yoWfWrb_uw\n\t12vFWxJanxGw1Fkw4Yyr42v3yq9r1v9ryfAr4akFWSkwn7Cw17Ww1DZr13XrZ5WrWfCasr\n\tCr1agFy2y34jkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUj6pBDUUUUU==", "X-Originating-IP": "[166.111.70.58]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/xtbBRQNNelO-wXjiNgAAsw", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] igb: Fix a memory leak in igb_probe", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In error handling code of igb_probe, the memory adapter->shadow_vfta \nallocated by kcalloc in igb_sw_init is not freed. So when register_netdev \nor igb_init_i2c is failed, a memory leak will occur.\nThis patch adds kfree to fix it.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 2f70a9b..3efb757 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2645,6 +2645,7 @@ err_eeprom:\n \tif (hw->flash_address)\n \t\tiounmap(hw->flash_address);\n err_sw_init:\n+\tkfree(adapter->shadow_vfta);\n \tigb_clear_interrupt_scheme(adapter);\n \tpci_iounmap(pdev, hw->hw_addr);\n err_ioremap:\n", "prefixes": [] }