Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/502990/?format=api
{ "id": 502990, "url": "http://patchwork.ozlabs.org/api/patches/502990/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438573504-369-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1438573504-369-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2015-08-03T03:45:04", "name": "e1000e: Fix a null dereference in e1000_open", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6d079e721efa3013a740f5ffc127a30f7963edcd", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438573504-369-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/502990/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/502990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id ABA6D1402DD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 3 Aug 2015 14:01:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CBCC28AB9B;\n\tMon, 3 Aug 2015 04:01:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F0o+jYTNbPtb; Mon, 3 Aug 2015 04:01:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E61F48A4C6;\n\tMon, 3 Aug 2015 04:01:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 01A7D1C16AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 04:01:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EDC643116F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 04:01:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MvPwYo1FoDtF for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 04:01:06 +0000 (UTC)", "from m50-132.163.com (m50-132.163.com [123.125.50.132])\n\tby silver.osuosl.org (Postfix) with ESMTP id C61C73119F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 04:01:05 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [173.252.200.40])\n\tby smtp2 (Coremail) with SMTP id DNGowEBpcvLC475VsE1zAQ--.3608S2;\n\tMon, 03 Aug 2015 11:45:15 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=U7OBrmQm;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:15:42 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=LJVWOEIuEgdGEilfUW\n\tpObXiJI5PioBsK2VkgzSuLZZ0=; b=U7OBrmQm4IETwDlF4QMnTTGrr0hqzCCOFh\n\tWRWSy3W9Gnxg2woR4yJSgV0QgbUllgP9stXTfZjFDp7MqayNC3kl6dTEQ86/Uen7\n\t0+klHLB+EPME37VV+ZiyhxqEA4ogP3J6RJZ/Bq0t5nE37+Rfin8mFlVgOGuev36y\n\tef6xkla6Q=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tjesse.brandeburg@intel.com", "Date": "Mon, 3 Aug 2015 11:45:04 +0800", "Message-Id": "<1438573504-369-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "DNGowEBpcvLC475VsE1zAQ--.3608S2", "X-Coremail-Antispam": "1Uf129KBjvdXoW7Xr43tFWrAry8Jry3KF13CFg_yoWkKrX_ur\n\t1kur1xJrW5Aa4F9F1rZr47A34j9r1DXa97ZFyft393uFnrAr48Wwn5Wry7WF1Sga4rZFWk\n\tJry3XFW5Aw4FkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8_hLUUUUUU==", "X-Originating-IP": "[173.252.200.40]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/1tbipQ1LelUL6A1-wAAAsd", "Cc": "Jia-Ju Bai <baijiaju1990@163.com>, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Fix a null dereference in\n\te1000_open", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When e1000e_setup_rx_resources is failed in e1000_open,\ne1000e_free_tx_resources in \"err_setup_rx\" segment is executed.\n\"writel(0, tx_ring->head)\" statement in e1000_clean_tx_ring\nin e1000e_free_tx_resources will cause a null dereference(crash), \nbecause \"tx_ring->head\" is only assigned in e1000_configure_tx\nin e1000_configure, but it is after e1000e_setup_rx_resources.\nThis patch adds a check to fix it.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 89d788d..838ec8e 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -2448,7 +2448,8 @@ static void e1000_clean_tx_ring(struct e1000_ring *tx_ring)\n \ttx_ring->next_to_use = 0;\n \ttx_ring->next_to_clean = 0;\n \n-\twritel(0, tx_ring->head);\n+\tif (tx_ring->head)\n+\t\twritel(0, tx_ring->head);\n \tif (adapter->flags2 & FLAG2_PCIM2PCI_ARBITER_WA)\n \t\te1000e_update_tdt_wa(tx_ring, 0);\n \telse\n", "prefixes": [] }