Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/502978/?format=api
{ "id": 502978, "url": "http://patchwork.ozlabs.org/api/patches/502978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438569648-20469-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1438569648-20469-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2015-08-03T02:40:48", "name": "e100: Release skb when DMA mapping is failed in e100_xmit_prepare", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f8d33928834f4e47aa470704b44e8f0d9e36ab2f", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438569648-20469-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/502978/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/502978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 36C5A1402D7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 3 Aug 2015 12:41:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 58F322E081;\n\tMon, 3 Aug 2015 02:41:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4tbO6TTcxDYO; Mon, 3 Aug 2015 02:41:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 748AA2550A;\n\tMon, 3 Aug 2015 02:41:13 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 199B31C1323\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:41:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 00AC88748A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:41:13 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 181ff+AJWzCf for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:41:08 +0000 (UTC)", "from m50-133.163.com (m50-133.163.com [123.125.50.133])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0AB8D82196\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:41:07 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [173.252.200.40])\n\tby smtp3 (Coremail) with SMTP id DdGowEDJvUWz1L5VZ4edAA--.177S2;\n\tMon, 03 Aug 2015 10:41:01 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=EZ7tahYi;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=uOkVQT7Yjw0TqYJBi3\n\txKbXoycVWkQVR2Qzhe5hUogmA=; b=EZ7tahYiMLqwmPmj1iEhKE8x9/irIosc6b\n\tRYF4bhIleMTilJ3O7tIcR0HA1Id9ccbkmJJPey7Ikx7rVXxBeqq92uBnSTuV2pdV\n\tlDExaRjxrO3NzPC613bEYkIpjrZHwI/H2CSq4RBcjKVTy4/UhQ/CNBfXjVTLpDlP\n\tb2UXh5e6E=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tjesse.brandeburg@intel.com", "Date": "Mon, 3 Aug 2015 10:40:48 +0800", "Message-Id": "<1438569648-20469-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "DdGowEDJvUWz1L5VZ4edAA--.177S2", "X-Coremail-Antispam": "1Uf129KBjvdXoW7XFy8ZF4fCFy7Kw1xCFW7Arb_yoWkGFbEgF\n\ty09ryxGw45AFySqw4jvr15Z3sIkryDX348Zr97ta43XrnxArs7GrZ7uFs3Wrs7Ww4xCFyD\n\tC343WFyxC34qvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUntKItUUUUU==", "X-Originating-IP": "[173.252.200.40]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/1tbiTh5LelUCnHMENwAAsq", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] e100: Release skb when DMA mapping is\n\tfailed in e100_xmit_prepare", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When pci_dma_mapping_error in e100_xmit_prepare is failed, the skb buffer\nallocated by netdev_alloc_skb_ip_align in e100_rx_alloc_skb is not\nreleased, which causes a possible resource leak.\nThis patch adds error handling code to fix it.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/e100.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c\nindex d2657a4..cc90616 100644\n--- a/drivers/net/ethernet/intel/e100.c\n+++ b/drivers/net/ethernet/intel/e100.c\n@@ -1770,8 +1770,11 @@ static int e100_xmit_prepare(struct nic *nic, struct cb *cb,\n \tdma_addr = pci_map_single(nic->pdev,\n \t\t\t\t skb->data, skb->len, PCI_DMA_TODEVICE);\n \t/* If we can't map the skb, have the upper layer try later */\n-\tif (pci_dma_mapping_error(nic->pdev, dma_addr))\n+\tif (pci_dma_mapping_error(nic->pdev, dma_addr)) {\n+\t\tdev_kfree_skb_any(skb);\n+\t\tskb = NULL;\n \t\treturn -ENOMEM;\n+\t}\n \n \t/*\n \t * Use the last 4 bytes of the SKB payload packet as the CRC, used for\n", "prefixes": [] }