Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/502974/?format=api
{ "id": 502974, "url": "http://patchwork.ozlabs.org/api/patches/502974/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438568228-13288-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1438568228-13288-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2015-08-03T02:17:08", "name": "e100: Add a check after pci_pool_create to avoid null pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9b8ffe4a683db309381c411d567201adb3e6c9b8", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1438568228-13288-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/502974/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/502974/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id D75DF1402A6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 3 Aug 2015 12:17:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 10F4D32BC4;\n\tMon, 3 Aug 2015 02:17:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id atf4i7tEOxZF; Mon, 3 Aug 2015 02:17:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F1B3332AC1;\n\tMon, 3 Aug 2015 02:17:30 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9AEFE1C1323\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:17:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 953D48B8A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:17:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QAW4RANA3llA for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:17:28 +0000 (UTC)", "from m50-133.163.com (m50-133.163.com [123.125.50.133])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 357838B89E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Aug 2015 02:17:27 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [173.252.200.40])\n\tby smtp3 (Coremail) with SMTP id DdGowED57EQnz75VM4icAA--.119S2;\n\tMon, 03 Aug 2015 10:17:21 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=dxEqfgSA;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=ks89pKxbDgSAkDyB6n\n\tFf2Bc7v3Igm9sEHnUsQNEZK70=; b=dxEqfgSAeoN4hka5IRULQ5iq/4H6KsfrJh\n\tRoA/3VRtjY1KcfKguBlc6g7Gss9p6lYXsHl7zYNur+66y5o06/W3ZZ2UiZPG5VFL\n\tzDJ8CUVv4YfBHSvckQ/6toJm1nQbjVfqS5d39j2FuHbeRlN5FWaXqKJ1QCnPvpe5\n\tXTLsHkbIE=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tjesse.brandeburg@intel.com", "Date": "Mon, 3 Aug 2015 10:17:08 +0800", "Message-Id": "<1438568228-13288-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "DdGowED57EQnz75VM4icAA--.119S2", "X-Coremail-Antispam": "1Uf129KBjvJXoWxJr17Zr1xGr1UGry8Kw47XFb_yoW8Jw4xpa\n\tnIva43Cr48X343Ww18JF18ZF90va1jqas8WFy7Awn5ua97Jry8tFWrKFW0kryUurWDGa43\n\ttF1jyry7CFs8tw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jzeHDUUUUU=", "X-Originating-IP": "[173.252.200.40]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/1tbiYxJLelD+dxzYFQAAsI", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] e100: Add a check after pci_pool_create\n\tto avoid null pointer dereference", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver lacks the check of nic->cbs_pool after pci_pool_create\nin e100_probe. When this function is failed, a null pointer dereference \noccurs when pci_pool_alloc uses nic->cbs_pool in e100_alloc_cbs.\nThis patch adds a check and related error handling code to fix it.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/e100.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c\nindex d2657a4..767c161 100644\n--- a/drivers/net/ethernet/intel/e100.c\n+++ b/drivers/net/ethernet/intel/e100.c\n@@ -2967,6 +2967,11 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t nic->params.cbs.max * sizeof(struct cb),\n \t\t\t sizeof(u32),\n \t\t\t 0);\n+\tif (!nic->cbs_pool) {\n+\t\tnetif_err(nic, probe, nic->netdev, \"Cannot create DMA pool, aborting\\n\");\n+\t\terr = -ENOMEM;\n+\t\tgoto err_out_pool;\n+\t}\n \tnetif_info(nic, probe, nic->netdev,\n \t\t \"addr 0x%llx, irq %d, MAC addr %pM\\n\",\n \t\t (unsigned long long)pci_resource_start(pdev, use_io ? 1 : 0),\n@@ -2974,6 +2979,8 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \n \treturn 0;\n \n+err_out_pool:\n+\tunregister_netdev(netdev);\n err_out_free:\n \te100_free(nic);\n err_out_iounmap:\n", "prefixes": [] }