Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/501835/?format=api
{ "id": 501835, "url": "http://patchwork.ozlabs.org/api/patches/501835/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150729203814.10732.38094.stgit@gimli.home/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150729203814.10732.38094.stgit@gimli.home>", "list_archive_url": null, "date": "2015-07-29T20:38:15", "name": "[v2,1/2] igb: Teardown SR-IOV before unregister_netdev()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83367892cc7f8d08dffa8321f7a30d452b7de10d", "submitter": { "id": 4123, "url": "http://patchwork.ozlabs.org/api/people/4123/?format=api", "name": "Alex Williamson", "email": "alex.williamson@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150729203814.10732.38094.stgit@gimli.home/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/501835/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/501835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 4D6031402DE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Jul 2015 06:38:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 615299216E;\n\tWed, 29 Jul 2015 20:38:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UztMhCQIY0Zi; Wed, 29 Jul 2015 20:38:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CB81692164;\n\tWed, 29 Jul 2015 20:38:18 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B01711C100A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Jul 2015 20:38:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AC43F955BD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Jul 2015 20:38:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VR5B5NzGuwmp for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Jul 2015 20:38:16 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 8E3B39558D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Jul 2015 20:38:16 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 01F7183F8C;\n\tWed, 29 Jul 2015 20:38:15 +0000 (UTC)", "from gimli.home (ovpn-113-179.phx2.redhat.com [10.3.113.179])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t6TKcFL6017232; Wed, 29 Jul 2015 16:38:15 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Alex Williamson <alex.williamson@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org, davem@davemloft.net,\n\tjeffrey.t.kirsher@intel.com", "Date": "Wed, 29 Jul 2015 14:38:15 -0600", "Message-ID": "<20150729203814.10732.38094.stgit@gimli.home>", "In-Reply-To": "<20150729203726.10732.91020.stgit@gimli.home>", "References": "<20150729203726.10732.91020.stgit@gimli.home>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH v2 1/2] igb: Teardown SR-IOV before\n\tunregister_netdev()", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When the .remove() callback for a PF is called, SR-IOV support for the\ndevice is disabled, which requires unbinding and removing the VFs.\nThe VFs may be in-use either by the host kernel or userspace, such as\nassigned to a VM through vfio-pci. In this latter case, the VFs may\nbe removed either by shutting down the VM or hot-unplugging the\ndevices from the VM. Unfortunately in the case of a Windows 2012 R2\nguest, hot-unplug is broken due to the ordering of the PF driver\nteardown. Disabling SR-IOV prior to unregister_netdev() avoids this\nissue.\n\nSigned-off-by: Alex Williamson <alex.williamson@redhat.com>\nAcked-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 2f70a9b..417cc9c 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2805,14 +2805,14 @@ static void igb_remove(struct pci_dev *pdev)\n \t */\n \tigb_release_hw_control(adapter);\n \n-\tunregister_netdev(netdev);\n-\n-\tigb_clear_interrupt_scheme(adapter);\n-\n #ifdef CONFIG_PCI_IOV\n \tigb_disable_sriov(pdev);\n #endif\n \n+\tunregister_netdev(netdev);\n+\n+\tigb_clear_interrupt_scheme(adapter);\n+\n \tpci_iounmap(pdev, hw->hw_addr);\n \tif (hw->flash_address)\n \t\tiounmap(hw->flash_address);\n", "prefixes": [ "v2", "1/2" ] }