Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/499802/?format=api
{ "id": 499802, "url": "http://patchwork.ozlabs.org/api/patches/499802/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1437688476-3399-4-git-send-email-sbaugh@catern.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1437688476-3399-4-git-send-email-sbaugh@catern.com>", "list_archive_url": null, "date": "2015-07-23T21:54:34", "name": "e1000: make eeprom read/write scheduler friendly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "41f8182b0dba6125172ea65baa997f04057417c7", "submitter": { "id": 66916, "url": "http://patchwork.ozlabs.org/api/people/66916/?format=api", "name": "Spencer Baugh", "email": "sbaugh@catern.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1437688476-3399-4-git-send-email-sbaugh@catern.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/499802/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/499802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 22FD1140B04\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 25 Jul 2015 02:23:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1222C95A87;\n\tFri, 24 Jul 2015 16:23:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xehMhnojDync; Fri, 24 Jul 2015 16:23:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A4E5A959F1;\n\tFri, 24 Jul 2015 16:23:31 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E78931C2B93\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 22:03:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DB5F933696\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 22:03:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oTCyutid1U4g for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 22:03:45 +0000 (UTC)", "from mail.catern.com (catern.com [104.131.201.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C170933597\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 22:03:45 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.catern.com (Postfix) with ESMTPSA id EB4F447A14;\n\tThu, 23 Jul 2015 21:55:37 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:08:06 by SQLgrey-1.7.6", "From": "Spencer Baugh <sbaugh@catern.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tJesse Brandeburg <jesse.brandeburg@intel.com>,\n\tShannon Nelson <shannon.nelson@intel.com>,\n\tCarolyn Wyborny <carolyn.wyborny@intel.com>,\n\tDon Skidmore <donald.c.skidmore@intel.com>,\n\tMatthew Vick <matthew.vick@intel.com>,\n\tJohn Ronciak <john.ronciak@intel.com>,\n\tMitch Williams <mitch.a.williams@intel.com>,\n\tintel-wired-lan@lists.osuosl.org (open list:INTEL ETHERNET DRIVERS), \n\tnetdev@vger.kernel.org (open list:NETWORKING DRIVERS),\n\tlinux-kernel@vger.kernel.org (open list)", "Date": "Thu, 23 Jul 2015 14:54:34 -0700", "Message-Id": "<1437688476-3399-4-git-send-email-sbaugh@catern.com>", "X-Mailman-Approved-At": "Fri, 24 Jul 2015 16:23:30 +0000", "Cc": "Spencer Baugh <sbaugh@catern.com>, Joern Engel <joern@logfs.org>,\n\tSpencer Baugh <Spencer.baugh@purestorage.com>,\n\tJoern Engel <joern@purestorage.com>", "Subject": "[Intel-wired-lan] [PATCH] e1000: make eeprom read/write scheduler\n\tfriendly", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Joern Engel <joern@logfs.org>\n\nCode was responsible for ~150ms scheduler latencies.\n\nSigned-off-by: Joern Engel <joern@logfs.org>\nSigned-off-by: Spencer Baugh <sbaugh@catern.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_hw.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c\nindex 45c8c864..e74e9dd 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c\n@@ -106,7 +106,7 @@ u16 e1000_igp_cable_length_table[IGP01E1000_AGC_LENGTH_TABLE_SIZE] = {\n \t 120, 120\n };\n \n-static DEFINE_SPINLOCK(e1000_eeprom_lock);\n+static DEFINE_MUTEX(e1000_eeprom_lock);\n static DEFINE_SPINLOCK(e1000_phy_lock);\n \n /**\n@@ -3882,9 +3882,9 @@ static s32 e1000_spi_eeprom_ready(struct e1000_hw *hw)\n s32 e1000_read_eeprom(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)\n {\n \ts32 ret;\n-\tspin_lock(&e1000_eeprom_lock);\n+\tmutex_lock(&e1000_eeprom_lock);\n \tret = e1000_do_read_eeprom(hw, offset, words, data);\n-\tspin_unlock(&e1000_eeprom_lock);\n+\tmutex_unlock(&e1000_eeprom_lock);\n \treturn ret;\n }\n \n@@ -3972,6 +3972,7 @@ static s32 e1000_do_read_eeprom(struct e1000_hw *hw, u16 offset, u16 words,\n \t\t\t */\n \t\t\tdata[i] = e1000_shift_in_ee_bits(hw, 16);\n \t\t\te1000_standby_eeprom(hw);\n+\t\t\tcond_resched();\n \t\t}\n \t}\n \n@@ -4056,9 +4057,9 @@ s32 e1000_update_eeprom_checksum(struct e1000_hw *hw)\n s32 e1000_write_eeprom(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)\n {\n \ts32 ret;\n-\tspin_lock(&e1000_eeprom_lock);\n+\tmutex_lock(&e1000_eeprom_lock);\n \tret = e1000_do_write_eeprom(hw, offset, words, data);\n-\tspin_unlock(&e1000_eeprom_lock);\n+\tmutex_unlock(&e1000_eeprom_lock);\n \treturn ret;\n }\n \n@@ -4124,6 +4125,7 @@ static s32 e1000_write_eeprom_spi(struct e1000_hw *hw, u16 offset, u16 words,\n \t\t\treturn -E1000_ERR_EEPROM;\n \n \t\te1000_standby_eeprom(hw);\n+\t\tcond_resched();\n \n \t\t/* Send the WRITE ENABLE command (8 bit opcode ) */\n \t\te1000_shift_out_ee_bits(hw, EEPROM_WREN_OPCODE_SPI,\n@@ -4232,6 +4234,7 @@ static s32 e1000_write_eeprom_microwire(struct e1000_hw *hw, u16 offset,\n \n \t\t/* Recover from write */\n \t\te1000_standby_eeprom(hw);\n+\t\tcond_resched();\n \n \t\twords_written++;\n \t}\n", "prefixes": [] }