Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/499523/?format=api
{ "id": 499523, "url": "http://patchwork.ozlabs.org/api/patches/499523/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1437684884-222825-2-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1437684884-222825-2-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-07-23T20:54:30", "name": "[next,S9,01/15] i40e/i40evf: fix up type clash in i40e_aq_rc_to_posix conversion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3b86d1334a0624908741c7475978bc22d948a297", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1437684884-222825-2-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/499523/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/499523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 9D95E140D19\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 Jul 2015 06:53:42 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E3F8FA43A2;\n\tThu, 23 Jul 2015 20:53:41 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id m0Tne59GGJEv; Thu, 23 Jul 2015 20:53:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5573FA438E;\n\tThu, 23 Jul 2015 20:53:41 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9157E1BFA6C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 20:53:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8B48B91FF8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 20:53:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0DJZs+4ylwI9 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 20:53:40 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0B27091FF1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jul 2015 20:53:39 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 23 Jul 2015 13:53:39 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby fmsmga001.fm.intel.com with ESMTP; 23 Jul 2015 13:53:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,533,1432623600\"; d=\"scan'208\";a=\"753353275\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 23 Jul 2015 16:54:30 -0400", "Message-Id": "<1437684884-222825-2-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1437684884-222825-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1437684884-222825-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S9 01/15] i40e/i40evf: fix up type\n\tclash in i40e_aq_rc_to_posix conversion", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nThe error code sent into i40e_aq_rc_to_posix() are signed values, so we\nreally need to treat them as such.\n\nReported-by: Helin Zhang <helin.zhang@intel.com>\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: I3d1ae0ee9ae0b1b6f5fc424f8b8cc58b0ea93203\n---\n drivers/net/ethernet/intel/i40e/i40e_adminq.h | 9 ++++++---\n drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 9 ++++++---\n 2 files changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h b/drivers/net/ethernet/intel/i40e/i40e_adminq.h\nindex 28e519a..299e3d3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h\n@@ -108,9 +108,10 @@ struct i40e_adminq_info {\n \n /**\n * i40e_aq_rc_to_posix - convert errors to user-land codes\n- * aq_rc: AdminQ error code to convert\n+ * aq_ret: AdminQ handler error code can override aq_rc\n+ * aq_rc: AdminQ firmware error code to convert\n **/\n-static inline int i40e_aq_rc_to_posix(u32 aq_ret, u16 aq_rc)\n+static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc)\n {\n \tint aq_to_posix[] = {\n \t\t0, /* I40E_AQ_RC_OK */\n@@ -142,8 +143,10 @@ static inline int i40e_aq_rc_to_posix(u32 aq_ret, u16 aq_rc)\n \tif (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT)\n \t\treturn -EAGAIN;\n \n-\tif (aq_rc >= ARRAY_SIZE(aq_to_posix))\n+\tif (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])) ||\n+\t aq_rc < 0)\n \t\treturn -ERANGE;\n+\n \treturn aq_to_posix[aq_rc];\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\nindex ef43d68..c4efa6b 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\n@@ -108,9 +108,10 @@ struct i40e_adminq_info {\n \n /**\n * i40e_aq_rc_to_posix - convert errors to user-land codes\n- * aq_rc: AdminQ error code to convert\n+ * aq_ret: AdminQ handler error code can override aq_rc\n+ * aq_rc: AdminQ firmware error code to convert\n **/\n-static inline int i40e_aq_rc_to_posix(u32 aq_ret, u16 aq_rc)\n+static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc)\n {\n \tint aq_to_posix[] = {\n \t\t0, /* I40E_AQ_RC_OK */\n@@ -142,8 +143,10 @@ static inline int i40e_aq_rc_to_posix(u32 aq_ret, u16 aq_rc)\n \tif (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT)\n \t\treturn -EAGAIN;\n \n-\tif (aq_rc >= ARRAY_SIZE(aq_to_posix))\n+\tif (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])) ||\n+\t aq_rc < 0)\n \t\treturn -ERANGE;\n+\n \treturn aq_to_posix[aq_rc];\n }\n \n", "prefixes": [ "next", "S9", "01/15" ] }