Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/493933/?format=api
{ "id": 493933, "url": "http://patchwork.ozlabs.org/api/patches/493933/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436571370-103673-5-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1436571370-103673-5-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-07-10T23:36:00", "name": "[next,S8,05/15] i40e: Fix legacy interrupt mode in the driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ea3644cfb084c138393910e44fe055a2ce2cfa15", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436571370-103673-5-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/493933/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/493933/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id A5B4A1402BE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 11 Jul 2015 09:34:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 07CD88BB3F;\n\tFri, 10 Jul 2015 23:34:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FCTszhuT7Nop; Fri, 10 Jul 2015 23:34:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 319448C202;\n\tFri, 10 Jul 2015 23:34:02 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E164A1C21C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DF89D938F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:59 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CRENlaJifIkk for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:58 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EF7119391C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:57 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 10 Jul 2015 16:33:42 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga001.jf.intel.com with ESMTP; 10 Jul 2015 16:33:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,450,1432623600\"; d=\"scan'208\";a=\"726728079\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 10 Jul 2015 19:36:00 -0400", "Message-Id": "<1436571370-103673-5-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1436571370-103673-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1436571370-103673-1-git-send-email-catherine.sullivan@intel.com>", "Cc": "Anjali Singhai Jain <anjali.singhai@intel.com>", "Subject": "[Intel-wired-lan] [intel-wired-lan][next PATCH S8 05/15] i40e: Fix\n\tlegacy interrupt mode in the driver", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nThis patch fixes the driver flow to take into account legacy interrupts.\nOver time we added code that assumes MSIX is the only mode that the\ndriver runs in. It also enables a legacy workaround to trigger SWINT\nwhen the TX ring has non-cache aligned descriptors pending and interrupts\nare disabled.\n\nWe work with a single vector in MSI mode too, so apply the same\nrestrictions as Legacy.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nChange-ID: I826ddff1f9bd45d2dbe11f56a3ddcef0dbf42563\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ef99c16..d7a8276 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1480,7 +1480,10 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,\n \t * vectors available and so we need to lower the used\n \t * q count.\n \t */\n-\tqcount = min_t(int, vsi->alloc_queue_pairs, pf->num_lan_msix);\n+\tif (pf->flags & I40E_FLAG_MSIX_ENABLED)\n+\t\tqcount = min_t(int, vsi->alloc_queue_pairs, pf->num_lan_msix);\n+\telse\n+\t\tqcount = vsi->alloc_queue_pairs;\n \tnum_tc_qps = qcount / numtc;\n \tnum_tc_qps = min_t(int, num_tc_qps, i40e_pf_get_max_q_per_tc(pf));\n \n@@ -1544,7 +1547,7 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,\n \tif ((vsi->type == I40E_VSI_MAIN) && (numtc == 1)) {\n \t\tif (vsi->req_queue_pairs > 0)\n \t\t\tvsi->num_queue_pairs = vsi->req_queue_pairs;\n-\t\telse\n+\t\telse if (pf->flags & I40E_FLAG_MSIX_ENABLED)\n \t\t\tvsi->num_queue_pairs = pf->num_lan_msix;\n \t}\n \n@@ -3346,7 +3349,7 @@ static irqreturn_t i40e_fdir_clean_ring(int irq, void *data)\n * @v_idx: vector index\n * @qp_idx: queue pair index\n **/\n-static void map_vector_to_qp(struct i40e_vsi *vsi, int v_idx, int qp_idx)\n+static void i40e_map_vector_to_qp(struct i40e_vsi *vsi, int v_idx, int qp_idx)\n {\n \tstruct i40e_q_vector *q_vector = vsi->q_vectors[v_idx];\n \tstruct i40e_ring *tx_ring = vsi->tx_rings[qp_idx];\n@@ -3400,7 +3403,7 @@ static void i40e_vsi_map_rings_to_vectors(struct i40e_vsi *vsi)\n \t\tq_vector->tx.ring = NULL;\n \n \t\twhile (num_ringpairs--) {\n-\t\t\tmap_vector_to_qp(vsi, v_start, qp_idx);\n+\t\t\ti40e_map_vector_to_qp(vsi, v_start, qp_idx);\n \t\t\tqp_idx++;\n \t\t\tqp_remaining--;\n \t\t}\n@@ -8728,6 +8731,11 @@ static int i40e_vsi_setup_vectors(struct i40e_vsi *vsi)\n \t\tgoto vector_setup_out;\n \t}\n \n+\t/* In Legacy mode, we do not have to get any other vector since we\n+\t * piggyback on the misc/ICR0 for queue interrupts.\n+\t*/\n+\tif (!(pf->flags & I40E_FLAG_MSIX_ENABLED))\n+\t\treturn ret;\n \tif (vsi->num_q_vectors)\n \t\tvsi->base_vector = i40e_get_lump(pf, pf->irq_pile,\n \t\t\t\t\t\t vsi->num_q_vectors, vsi->idx);\n", "prefixes": [ "next", "S8", "05/15" ] }