Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/493922/?format=api
{ "id": 493922, "url": "http://patchwork.ozlabs.org/api/patches/493922/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436571370-103673-8-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1436571370-103673-8-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-07-10T23:36:03", "name": "[next,S8,08/15] i40e: Fix comment for ethtool diagnostic link test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9a643f05832a5a385cf452882941c706809938f0", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436571370-103673-8-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/493922/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/493922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 100E91402B4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 11 Jul 2015 09:34:02 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4B6768BA2C;\n\tFri, 10 Jul 2015 23:34:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ves8U2z2Mci2; Fri, 10 Jul 2015 23:34:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 356218B8A2;\n\tFri, 10 Jul 2015 23:34:00 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 99C5A1C21C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 959FD938FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:58 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BlasULxM-+Kk for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:58 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B1D049390A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 23:33:57 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 10 Jul 2015 16:33:44 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby orsmga001.jf.intel.com with ESMTP; 10 Jul 2015 16:33:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,450,1432623600\"; d=\"scan'208\";a=\"726728100\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 10 Jul 2015 19:36:03 -0400", "Message-Id": "<1436571370-103673-8-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1436571370-103673-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1436571370-103673-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [intel-wired-lan][next PATCH S8 08/15] i40e: Fix\n\tcomment for ethtool diagnostic link test", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Greg Rose <gregory.v.rose@intel.com>\n\nThe existing comment is incorrect. Add new comment to point out that the\nPF reset does not affect link but if the reset is changed to a different\ntype that does affect link then the link test would need to be moved to\nbefore the reset.\n\nReported-by: Jeremiah Kyle <jeremiah.kyle@intel.com>\nSigned-off-by: Greg Rose <gregory.v.rose@intel.com>\nChange-ID: I28d786f46e9465860babdee61c1dba51016464df\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 74c16a1..62824f5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1626,11 +1626,13 @@ static void i40e_diag_test(struct net_device *netdev,\n \t\t\t/* indicate we're in test mode */\n \t\t\tdev_close(netdev);\n \t\telse\n+\t\t\t/* This reset does not affect link - if it is\n+\t\t\t * changed to a type of reset that does affect\n+\t\t\t * link then the following link test would have\n+\t\t\t * to be moved to before the reset\n+\t\t\t */\n \t\t\ti40e_do_reset(pf, BIT(__I40E_PF_RESET_REQUESTED));\n \n-\t\t/* Link test performed before hardware reset\n-\t\t * so autoneg doesn't interfere with test result\n-\t\t */\n \t\tif (i40e_link_test(netdev, &data[I40E_ETH_TEST_LINK]))\n \t\t\teth_test->flags |= ETH_TEST_FL_FAILED;\n \n", "prefixes": [ "next", "S8", "08/15" ] }