Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/493772/?format=api
{ "id": 493772, "url": "http://patchwork.ozlabs.org/api/patches/493772/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436533272-18070-1-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1436533272-18070-1-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2015-07-10T13:01:12", "name": "igb: do not re-init SR-IOV during probe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "07a58c1d8536a7acecafcc39ad2830fc04ddfa05", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436533272-18070-1-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/493772/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/493772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 36B641401AF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jul 2015 23:10:38 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 525DA986E5;\n\tFri, 10 Jul 2015 13:10:37 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CHMuYYMB-Qcm; Fri, 10 Jul 2015 13:10:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AB04C94655;\n\tFri, 10 Jul 2015 13:10:36 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9DDB41C28A1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 13:10:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 97DE6949CB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 13:10:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WDpaQbaketAW for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 13:10:34 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8AEF194655\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Jul 2015 13:10:34 +0000 (UTC)", "from int-mx14.intmail.prod.int.phx2.redhat.com\n\t(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8AB39A0CA6;\n\tFri, 10 Jul 2015 13:04:14 +0000 (UTC)", "from t530.redhat.com (ovpn-116-31.ams2.redhat.com [10.36.116.31])\n\tby int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t6AD4Cs6002647; Fri, 10 Jul 2015 09:04:13 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:06:18 by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 10 Jul 2015 15:01:12 +0200", "Message-Id": "<1436533272-18070-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.27", "Cc": "netdev@vger.kernel.org, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH] igb: do not re-init SR-IOV during probe", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "During driver probing the following code path is triggered.\nigb_probe\n->igb_sw_init\n ->igb_probe_vfs\n ->igb_pci_enable_sriov\n ->igb_sriov_reinit\n\nDoing the SR-IOV re-init is not necessary during probing since we're\nstarting from scratch. Here we can call igb_enable_sriov() right away.\n\nRunning igb_sriov_reinit() during igb_probe() also seems to cause\noccasional packet loss on some onboard 82576 NICs. Reproduced on\nDell and HP servers with onboard 82576 NICs.\nExample:\nIntel Corporation 82576 Gigabit Network Connection [8086:10c9] (rev 01)\nSubsystem: Dell Device [1028:0481]\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex f287186..7f41237 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2847,7 +2847,7 @@ static void igb_probe_vfs(struct igb_adapter *adapter)\n \t\treturn;\n \n \tpci_sriov_set_totalvfs(pdev, 7);\n-\tigb_pci_enable_sriov(pdev, max_vfs);\n+\tigb_enable_sriov(pdev, max_vfs);\n \n #endif /* CONFIG_PCI_IOV */\n }\n", "prefixes": [] }