Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/491661/?format=api
{ "id": 491661, "url": "http://patchwork.ozlabs.org/api/patches/491661/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436194656-31370-1-git-send-email-raanan.avargil@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1436194656-31370-1-git-send-email-raanan.avargil@intel.com>", "list_archive_url": null, "date": "2015-07-06T14:57:36", "name": "e1000e: Fix incorrect ASPM locking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7f0e9397f55bf42b76895ce56aa06948e31d1632", "submitter": { "id": 66787, "url": "http://patchwork.ozlabs.org/api/people/66787/?format=api", "name": "Raanan Avargil", "email": "raanan.avargil@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1436194656-31370-1-git-send-email-raanan.avargil@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/491661/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/491661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 07B94140216\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Jul 2015 00:58:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 12A8C33419;\n\tMon, 6 Jul 2015 14:58:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PHt0nCcV-rVY; Mon, 6 Jul 2015 14:58:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 694CF321D0;\n\tMon, 6 Jul 2015 14:58:14 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id AD50A1C1F36\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Jul 2015 14:58:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A7FD3954D3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Jul 2015 14:58:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Op4Hzl1QAi5i for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Jul 2015 14:58:12 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8FE59954DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Jul 2015 14:58:12 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 06 Jul 2015 07:58:11 -0700", "from unknown (HELO ccdpc198.iil.intel.com) ([143.185.160.81])\n\tby orsmga003.jf.intel.com with ESMTP; 06 Jul 2015 07:58:10 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,415,1432623600\"; d=\"scan'208\";a=\"600943659\"", "From": "Raanan Avargil <raanan.avargil@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 6 Jul 2015 17:57:36 +0300", "Message-Id": "<1436194656-31370-1-git-send-email-raanan.avargil@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Fix incorrect ASPM locking", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch fixes wrong locking usage.\nIn the context of slot reset, we should use lock.\nAnd during resume, there is no need of lock.\n\nReported-by: Bjorn Helgaas <bhelgaas@google.com>\nSigned-off-by: Raanan Avargil <raanan.avargil@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 6c153c1..7abe000 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -6466,7 +6466,7 @@ static int __e1000_resume(struct pci_dev *pdev)\n \tif (adapter->flags2 & FLAG2_DISABLE_ASPM_L1)\n \t\taspm_disable_flag |= PCIE_LINK_STATE_L1;\n \tif (aspm_disable_flag)\n-\t\te1000e_disable_aspm_locked(pdev, aspm_disable_flag);\n+\t\te1000e_disable_aspm(pdev, aspm_disable_flag);\n \n \tpci_set_master(pdev);\n \n@@ -6744,7 +6744,7 @@ static pci_ers_result_t e1000_io_slot_reset(struct pci_dev *pdev)\n \tif (adapter->flags2 & FLAG2_DISABLE_ASPM_L1)\n \t\taspm_disable_flag |= PCIE_LINK_STATE_L1;\n \tif (aspm_disable_flag)\n-\t\te1000e_disable_aspm(pdev, aspm_disable_flag);\n+\t\te1000e_disable_aspm_locked(pdev, aspm_disable_flag);\n \n \terr = pci_enable_device_mem(pdev);\n \tif (err) {\n", "prefixes": [] }