Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/487450/?format=api
{ "id": 487450, "url": "http://patchwork.ozlabs.org/api/patches/487450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1435019198-10957-1-git-send-email-mitch.a.williams@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1435019198-10957-1-git-send-email-mitch.a.williams@intel.com>", "list_archive_url": null, "date": "2015-06-23T00:26:38", "name": "[net] i40evf: don't configure unused RSS queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ee06304bab429f7e85bc27fefe00e2d3ba3aa3b2", "submitter": { "id": 967, "url": "http://patchwork.ozlabs.org/api/people/967/?format=api", "name": "Mitch Williams", "email": "mitch.a.williams@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1435019198-10957-1-git-send-email-mitch.a.williams@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/487450/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/487450/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 1279E140081\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 23 Jun 2015 10:27:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1AE379094D;\n\tTue, 23 Jun 2015 00:27:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7tu+jv+9k6Xh; Tue, 23 Jun 2015 00:27:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 740B2908D1;\n\tTue, 23 Jun 2015 00:27:56 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 22A971C1FF1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jun 2015 00:27:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1C42FA2089\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jun 2015 00:27:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fGc90VXfXw-Y for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jun 2015 00:27:54 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 90A76A207C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jun 2015 00:27:54 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 22 Jun 2015 17:27:55 -0700", "from themachine.jf.intel.com ([10.166.14.35])\n\tby orsmga002.jf.intel.com with ESMTP; 22 Jun 2015 17:27:54 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,662,1427785200\"; d=\"scan'208\";a=\"751411516\"", "From": "Mitch Williams <mitch.a.williams@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 22 Jun 2015 17:26:38 -0700", "Message-Id": "<1435019198-10957-1-git-send-email-mitch.a.williams@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [net PATCH] i40evf: don't configure unused RSS\n\tqueues", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver will only configure as many queues as there are available\nCPUs, up the the maximum number of queues. However, it always configures\nRSS as though it is using the maximum number of queues. This can cause\nthe device to drop a lot of RX traffic, as the packets get assigned to\nnonfunctional queues.\n\nFix this by only configuring RSS with the number of active queues.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 7c53aca..fef4843 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1460,7 +1460,7 @@ static void i40evf_configure_rss(struct i40evf_adapter *adapter)\n \tfor (i = 0; i <= I40E_VFQF_HLUT_MAX_INDEX; i++) {\n \t\tlut = 0;\n \t\tfor (j = 0; j < 4; j++) {\n-\t\t\tif (cqueue == adapter->vsi_res->num_queue_pairs)\n+\t\t\tif (cqueue == adapter->num_active_queues)\n \t\t\t\tcqueue = 0;\n \t\t\tlut |= ((cqueue) << (8 * j));\n \t\t\tcqueue++;\n", "prefixes": [ "net" ] }