Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/486868/?format=api
{ "id": 486868, "url": "http://patchwork.ozlabs.org/api/patches/486868/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1434736570-12137-2-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1434736570-12137-2-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-06-19T17:56:10", "name": "[net-next,2/2] fm10k: don't store sw_vid at reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e77f639c224cfa48c2b407036576185b7266520a", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1434736570-12137-2-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/486868/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/486868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 22F931401E7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 20 Jun 2015 03:56:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6C465897F3;\n\tFri, 19 Jun 2015 17:56:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 53QuCyeA19qo; Fri, 19 Jun 2015 17:56:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 018958C7B2;\n\tFri, 19 Jun 2015 17:56:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A042F1C25F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9B52494DFB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4cFsryw2Wi-E for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:13 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C6BEB94E56\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:13 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 19 Jun 2015 10:56:13 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.3.85])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Jun 2015 10:56:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,644,1427785200\"; d=\"scan'208\";a=\"591048468\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 19 Jun 2015 10:56:10 -0700", "Message-Id": "<1434736570-12137-2-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1434736570-12137-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1434736570-12137-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH net-next 2/2] fm10k: don't store sw_vid at\n\treset", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "If we store the sw_vid at reset of PF, then we accidentally prevent the\nVF from receiving the message to update its default VID. This only\noccurs if the VF is created before the PF has come up, which is the\nstandard way of creating VFs when using the module parameter.\n\nThis fixes an issue where we request the incorrect MAC/VLAN\ncombinations, and prevents us from accidentally reporting some frames as\nvlan tagged.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\nindex 94571e6e790c..0e25a80417b9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n@@ -228,9 +228,6 @@ int fm10k_iov_resume(struct pci_dev *pdev)\n \t\thw->iov.ops.set_lport(hw, vf_info, i,\n \t\t\t\t FM10K_VF_FLAG_MULTI_CAPABLE);\n \n-\t\t/* assign our default vid to the VF following reset */\n-\t\tvf_info->sw_vid = hw->mac.default_vid;\n-\n \t\t/* mailbox is disconnected so we don't send a message */\n \t\thw->iov.ops.assign_default_mac_vlan(hw, vf_info);\n \n", "prefixes": [ "net-next", "2/2" ] }