Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/486867/?format=api
{ "id": 486867, "url": "http://patchwork.ozlabs.org/api/patches/486867/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1434736570-12137-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1434736570-12137-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-06-19T17:56:09", "name": "[net-next,1/2] fm10k: allow creation of vlan interfaces even while down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6929e0874841f0a45f0787d6dce93fee891921c1", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1434736570-12137-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/486867/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/486867/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id C14E81401DA\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 20 Jun 2015 03:56:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D9A2C87C0F;\n\tFri, 19 Jun 2015 17:56:16 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rA75BX3i87-8; Fri, 19 Jun 2015 17:56:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CE4618AB1E;\n\tFri, 19 Jun 2015 17:56:15 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4B31E1C25F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4767F94FDE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id e0RY88vVoI1H for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:13 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B728094DFB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Jun 2015 17:56:13 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 19 Jun 2015 10:56:13 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.3.85])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Jun 2015 10:56:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,644,1427785200\"; d=\"scan'208\";a=\"591048467\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 19 Jun 2015 10:56:09 -0700", "Message-Id": "<1434736570-12137-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.4.3", "Subject": "[Intel-wired-lan] [PATCH net-next 1/2] fm10k: allow creation of\n\tvlan interfaces even while down", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "We re-sync upon going up, so there is little reason to worry about not\nsyncing immediately with switch. This prevents an error that occurs if\nyou add a vlan interface while down.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex b2065cb44edc..e1ceb3a2e2cd 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -779,6 +779,12 @@ static int fm10k_update_vid(struct net_device *netdev, u16 vid, bool set)\n \tif (!set && vid == hw->mac.default_vid)\n \t\treturn 0;\n \n+\t/* Do not throw an error if the interface is down. We will sync once\n+\t * we come up\n+\t */\n+\tif (test_bit(__FM10K_DOWN, &interface->state))\n+\t\treturn 0;\n+\n \tfm10k_mbx_lock(interface);\n \n \t/* only need to update the VLAN if not in promiscuous mode */\n", "prefixes": [ "net-next", "1/2" ] }