Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/485115/?format=api
{ "id": 485115, "url": "http://patchwork.ozlabs.org/api/patches/485115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150616184712.1966.44790.stgit@ahduyck-vm-fedora22/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150616184712.1966.44790.stgit@ahduyck-vm-fedora22>", "list_archive_url": null, "date": "2015-06-16T18:47:12", "name": "fm10k: Don't assume page fragments are page size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "25430d377557d47910be61c2283a6053240d6b42", "submitter": { "id": 64958, "url": "http://patchwork.ozlabs.org/api/people/64958/?format=api", "name": "Alexander Duyck", "email": "alexander.h.duyck@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150616184712.1966.44790.stgit@ahduyck-vm-fedora22/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/485115/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/485115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 4D56314018C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Jun 2015 04:47:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8A04695B49;\n\tTue, 16 Jun 2015 18:47:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1oO0x3nBuiiC; Tue, 16 Jun 2015 18:47:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8199495AF8;\n\tTue, 16 Jun 2015 18:47:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A9F651BFEEA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Jun 2015 18:47:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A1FF995B28\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Jun 2015 18:47:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fC4rrPVqEYFr for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Jun 2015 18:47:13 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id E484B95AF8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Jun 2015 18:47:13 +0000 (UTC)", "from int-mx14.intmail.prod.int.phx2.redhat.com\n\t(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2E81937C80E;\n\tTue, 16 Jun 2015 18:47:13 +0000 (UTC)", "from [192.168.122.149] (vpn-230-70.phx2.redhat.com [10.3.230.70])\n\tby int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t5GIlCbW003258; Tue, 16 Jun 2015 14:47:12 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Alexander Duyck <alexander.h.duyck@redhat.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tjeffrey.t.kirsher@intel.com", "Date": "Tue, 16 Jun 2015 11:47:12 -0700", "Message-ID": "<20150616184712.1966.44790.stgit@ahduyck-vm-fedora22>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.27", "Subject": "[Intel-wired-lan] [PATCH] fm10k: Don't assume page fragments are\n\tpage size", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This change pulls out the optimization that assumed that all fragments\nwould be limited to page size. That hasn't been the case for some time now\nand to assume this is incorrect as the TCP allocator can provide up to a\n32K page fragment.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 982fdcdc795b..620ff5e9dc59 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -1079,9 +1079,7 @@ netdev_tx_t fm10k_xmit_frame_ring(struct sk_buff *skb,\n \tstruct fm10k_tx_buffer *first;\n \tint tso;\n \tu32 tx_flags = 0;\n-#if PAGE_SIZE > FM10K_MAX_DATA_PER_TXD\n \tunsigned short f;\n-#endif\n \tu16 count = TXD_USE_COUNT(skb_headlen(skb));\n \n \t/* need: 1 descriptor per page * PAGE_SIZE/FM10K_MAX_DATA_PER_TXD,\n@@ -1089,12 +1087,9 @@ netdev_tx_t fm10k_xmit_frame_ring(struct sk_buff *skb,\n \t * + 2 desc gap to keep tail from touching head\n \t * otherwise try next time\n \t */\n-#if PAGE_SIZE > FM10K_MAX_DATA_PER_TXD\n \tfor (f = 0; f < skb_shinfo(skb)->nr_frags; f++)\n \t\tcount += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);\n-#else\n-\tcount += skb_shinfo(skb)->nr_frags;\n-#endif\n+\n \tif (fm10k_maybe_stop_tx(tx_ring, count + 3)) {\n \t\ttx_ring->tx_stats.tx_busy++;\n \t\treturn NETDEV_TX_BUSY;\n", "prefixes": [] }