Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/482393/?format=api
{ "id": 482393, "url": "http://patchwork.ozlabs.org/api/patches/482393/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/827ef89b421f872487196fb255d81e4f6d4976bc.1433877893.git.yanirx.lubetkin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<827ef89b421f872487196fb255d81e4f6d4976bc.1433877893.git.yanirx.lubetkin@intel.com>", "list_archive_url": null, "date": "2015-06-09T22:15:57", "name": "[3/5] e1000e: i219 - increase IPG for speed 10/100 full duplex", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "15783d167889e9be3327dc0e8274bcea729a4c82", "submitter": { "id": 66154, "url": "http://patchwork.ozlabs.org/api/people/66154/?format=api", "name": "Yanir Lubetkin", "email": "yanirx.lubetkin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/827ef89b421f872487196fb255d81e4f6d4976bc.1433877893.git.yanirx.lubetkin@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/482393/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/482393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id D70A9140758\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 10 Jun 2015 08:16:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 134068BA81;\n\tTue, 9 Jun 2015 22:16:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mhsBE4lx2J-c; Tue, 9 Jun 2015 22:16:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AEF518B0CE;\n\tTue, 9 Jun 2015 22:16:45 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id DBFED1C1E80\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jun 2015 22:16:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D905A8B7E8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jun 2015 22:16:43 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UGLPAB7Xa6c3 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jun 2015 22:16:43 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6F3CA8B60A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jun 2015 22:16:43 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 09 Jun 2015 15:16:42 -0700", "from unknown (HELO ccdpc064.localdomain.com) ([143.185.160.80])\n\tby orsmga003.jf.intel.com with ESMTP; 09 Jun 2015 15:16:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,584,1427785200\"; d=\"scan'208\";a=\"585003253\"", "From": "Yanir Lubetkin <yanirx.lubetkin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 10 Jun 2015 01:15:57 +0300", "Message-Id": "<827ef89b421f872487196fb255d81e4f6d4976bc.1433877893.git.yanirx.lubetkin@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<f60bcfb3d2cf6db3c53fe84b1620dad209976300.1433877893.git.yanirx.lubetkin@intel.com>", "References": "<f60bcfb3d2cf6db3c53fe84b1620dad209976300.1433877893.git.yanirx.lubetkin@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 3/5] e1000e: i219 - increase IPG for speed\n\t10/100 full duplex", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In SPT/Jacksonville, there were CRC errors in speed 10/100 full duplex.\nThe solution given by the HW team is to increase the IPG from 8 to 0xC\n\nSigned-off-by: Yanir Lubetkin <yanirx.lubetkin@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex bdb745d..af4431d 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1401,16 +1401,20 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \tif (((hw->mac.type == e1000_pch2lan) ||\n \t (hw->mac.type == e1000_pch_lpt) ||\n \t (hw->mac.type == e1000_pch_spt)) && link) {\n-\t\tu32 reg;\n+\t\tu16 speed, duplex;\n \n-\t\treg = er32(STATUS);\n+\t\te1000e_get_speed_and_duplex_copper(hw, &speed, &duplex);\n \t\ttipg_reg = er32(TIPG);\n \t\ttipg_reg &= ~E1000_TIPG_IPGT_MASK;\n \n-\t\tif (!(reg & (E1000_STATUS_FD | E1000_STATUS_SPEED_MASK))) {\n+\t\tif (duplex == HALF_DUPLEX && speed == SPEED_10) {\n \t\t\ttipg_reg |= 0xFF;\n \t\t\t/* Reduce Rx latency in analog PHY */\n \t\t\temi_val = 0;\n+\t\t} else if (hw->mac.type == e1000_pch_spt &&\n+\t\t\t duplex == FULL_DUPLEX && speed != SPEED_1000) {\n+\t\t\ttipg_reg |= 0xC;\n+\t\t\temi_val = 1;\n \t\t} else {\n \n \t\t\t/* Roll back the default values */\n", "prefixes": [ "3/5" ] }