Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480888/?format=api
{ "id": 480888, "url": "http://patchwork.ozlabs.org/api/patches/480888/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604212640.7229.93966.stgit@htfujina-fc.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150604212640.7229.93966.stgit@htfujina-fc.jf.intel.com>", "list_archive_url": null, "date": "2015-06-04T21:26:56", "name": "[v2] igb: report unsupported ethtool settings in set_coalesce", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2a7cb40970412cfb19928af1cf9cf1b6dac0f073", "submitter": { "id": 29211, "url": "http://patchwork.ozlabs.org/api/people/29211/?format=api", "name": "Fujinaka, Todd", "email": "todd.fujinaka@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604212640.7229.93966.stgit@htfujina-fc.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480888/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 6F1991401DA\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Jun 2015 07:28:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B676D9172B;\n\tThu, 4 Jun 2015 21:28:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2Mhg8UGSzFX0; Thu, 4 Jun 2015 21:28:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2B023916F3;\n\tThu, 4 Jun 2015 21:28:47 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BF5C41C1F3C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 21:28:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BA06B91702\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 21:28:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8MmEoGZ1kCDg for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 21:28:45 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2DA48916F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 21:28:45 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 04 Jun 2015 14:28:45 -0700", "from htfujina-fc.jf.intel.com ([134.134.145.128])\n\tby orsmga002.jf.intel.com with ESMTP; 04 Jun 2015 14:28:45 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,554,1427785200\"; d=\"scan'208\";a=\"741197040\"", "From": "Todd Fujinaka <todd.fujinaka@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 04 Jun 2015 14:26:56 -0700", "Message-ID": "<20150604212640.7229.93966.stgit@htfujina-fc.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2] igb: report unsupported ethtool\n\tsettings in set_coalesce", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "There are many settings possible using ethtool -C/--coalesce, but not\nall of them are supported in igb. Report failure when an unsupported\noption is set.\n\nSigned-off-by: Todd Fujinaka <todd.fujinaka@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 109cad9..b7b9c67 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2159,6 +2159,27 @@ static int igb_set_coalesce(struct net_device *netdev,\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n \tint i;\n \n+\tif (ec->rx_max_coalesced_frames ||\n+\t ec->rx_coalesce_usecs_irq ||\n+\t ec->rx_max_coalesced_frames_irq ||\n+\t ec->tx_max_coalesced_frames ||\n+\t ec->tx_coalesce_usecs_irq ||\n+\t ec->stats_block_coalesce_usecs ||\n+\t ec->use_adaptive_rx_coalesce ||\n+\t ec->use_adaptive_tx_coalesce ||\n+\t ec->pkt_rate_low ||\n+\t ec->rx_coalesce_usecs_low ||\n+\t ec->rx_max_coalesced_frames_low ||\n+\t ec->tx_coalesce_usecs_low ||\n+\t ec->tx_max_coalesced_frames_low ||\n+\t ec->pkt_rate_high ||\n+\t ec->rx_coalesce_usecs_high ||\n+\t ec->rx_max_coalesced_frames_high ||\n+\t ec->tx_coalesce_usecs_high ||\n+\t ec->tx_max_coalesced_frames_high ||\n+\t ec->rate_sample_interval)\n+\t\treturn -ENOTSUPP;\n+\n \tif ((ec->rx_coalesce_usecs > IGB_MAX_ITR_USECS) ||\n \t ((ec->rx_coalesce_usecs > 3) &&\n \t (ec->rx_coalesce_usecs < IGB_MIN_ITR_USECS)) ||\n", "prefixes": [ "v2" ] }