Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480682/?format=api
{ "id": 480682, "url": "http://patchwork.ozlabs.org/api/patches/480682/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433423247-27228-1-git-send-email-baijiaju1990@163.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1433423247-27228-1-git-send-email-baijiaju1990@163.com>", "list_archive_url": null, "date": "2015-06-04T13:07:27", "name": "e1000e: Cleanup qos request in error handling of e1000_open", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c5895a85d02f1b96d47da4d288154799427f66a", "submitter": { "id": 65398, "url": "http://patchwork.ozlabs.org/api/people/65398/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@163.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433423247-27228-1-git-send-email-baijiaju1990@163.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480682/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 035841401B5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Jun 2015 23:07:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3BBAB95C0C;\n\tThu, 4 Jun 2015 13:07:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eTHA+y3BtEpz; Thu, 4 Jun 2015 13:07:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CE1099594B;\n\tThu, 4 Jun 2015 13:07:44 +0000 (UTC)", "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 98FD31BF959\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 13:07:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8E5CD32C91\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 13:07:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3VoeJHsihTKt for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 13:07:42 +0000 (UTC)", "from m12-18.163.com (m12-18.163.com [220.181.12.18])\n\tby silver.osuosl.org (Postfix) with ESMTP id 73ECD32C33\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 13:07:41 +0000 (UTC)", "from bai-oslab.tsinghua.edu.cn (unknown [166.111.70.50])\n\tby smtp14 (Coremail) with SMTP id EsCowED5GWCTTXBVfQNLBg--.10589S2;\n\tThu, 04 Jun 2015 21:07:39 +0800 (CST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=ZBCM9fRr;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:Subject:Date:Message-Id; bh=Lodut1F+GCyZoBV7X/\n\t2fPa40IoqfsJjF+VLrEFynQDE=; b=ZBCM9fRrGKGafYU1xlzO2WHxk0vbvwRW3X\n\t6ROqUEC42yKT/1F259/K+dIHv49IwzPmJffc2ckIHYaL89qv8J1GZqw/YGV6v4SZ\n\tz8Yk3V7AalCF2SMFTgg/f0jm6W4JBJIkNrOii1XCzc82VnaTya+L/UwQxbUm1R2g\n\tW7MUYyQgM=", "From": "Jia-Ju Bai <baijiaju1990@163.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 4 Jun 2015 21:07:27 +0800", "Message-Id": "<1433423247-27228-1-git-send-email-baijiaju1990@163.com>", "X-Mailer": "git-send-email 1.7.9.5", "X-CM-TRANSID": "EsCowED5GWCTTXBVfQNLBg--.10589S2", "X-Coremail-Antispam": "1Uf129KBjvdXoWruFyfuF43Aw4UAFy7KF4fAFb_yoWfZFXEkr\n\t4Fvw1xtrW5JF1FyF47ArWfA34akFnrXFyFyFnaqa4fuw17Ar48Wryv9FnrXFs7G345uFZr\n\tJ34aqFW3A3yY9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRRT5l5UUUUU==", "X-Originating-IP": "[166.111.70.50]", "X-CM-SenderInfo": "xedlyx5dmximizq6il2tof0z/1tbiYw4PelD+cpbE8wAAsl", "Cc": "Jia-Ju Bai <baijiaju1990@163.com>", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error\n\thandling of e1000_open", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver lacks pm_qos_remove_request in error handling (err_req_irq) of\ne1000_open, and qos request inserted by pm_qos_add_request is not removed.\nThis patch add pm_qos_remove_request in error handling to fix it.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@163.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex c509a5c..f8c0dc4 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -4451,6 +4451,7 @@ static int e1000_open(struct net_device *netdev)\n \treturn 0;\n \n err_req_irq:\n+\tpm_qos_remove_request(&adapter->pm_qos_req);\n \te1000e_release_hw_control(adapter);\n \te1000_power_down_phy(adapter);\n \te1000e_free_rx_resources(adapter->rx_ring);\n", "prefixes": [] }