Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480676/?format=api
{ "id": 480676, "url": "http://patchwork.ozlabs.org/api/patches/480676/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604085637.GB22838@mwanda/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150604085637.GB22838@mwanda>", "list_archive_url": null, "date": "2015-06-04T08:56:38", "name": "[-next] i40e: fix some bit tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dafc92cb0fd87c1ec7f2048fdf60d8c5d7bc3460", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604085637.GB22838@mwanda/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480676/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480676/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id A49811401AF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Jun 2015 22:38:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 01A0F95FFC;\n\tThu, 4 Jun 2015 12:38:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ayruE0qAmj5T; Thu, 4 Jun 2015 12:38:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 62A1896016;\n\tThu, 4 Jun 2015 12:38:53 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E1DCA1C2012\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 08:56:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DA3928FE5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 08:56:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VF637+96olmd for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 08:56:57 +0000 (UTC)", "from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BEFA18FBD6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 08:56:57 +0000 (UTC)", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id t548usLV008587\n\t(version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 4 Jun 2015 08:56:55 GMT", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t548us8M023461\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); \n\tThu, 4 Jun 2015 08:56:54 GMT", "from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15])\n\tby userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tt548uslb020853; Thu, 4 Jun 2015 08:56:54 GMT", "from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway\n\tv4.0) with ESMTP ; Thu, 04 Jun 2015 01:56:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "Date": "Thu, 4 Jun 2015 11:56:38 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tGreg Rose <gregory.v.rose@intel.com>", "Message-ID": "<20150604085637.GB22838@mwanda>", "MIME-Version": "1.0", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "X-Mailman-Approved-At": "Thu, 04 Jun 2015 12:38:52 +0000", "Cc": "kernel-janitors@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [patch -next] i40e: fix some bit tests", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "These tests don't work as intended because __I40E_TESTING and\nI40E_VF_STAT_ACTIVE are bit numbers and not masks.\n\nFixes: e17bc411aea8 ('i40e: Disable offline diagnostics if VFs are enabled')\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 4653b6e..9fe6cd5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -980,7 +980,7 @@ static int i40e_pci_sriov_enable(struct pci_dev *pdev, int num_vfs)\n \tint pre_existing_vfs = pci_num_vf(pdev);\n \tint err = 0;\n \n-\tif (pf->state & __I40E_TESTING) {\n+\tif (test_bit(__I40E_TESTING, &pf->state)) {\n \t\tdev_warn(&pdev->dev,\n \t\t\t \"Cannot enable SR-IOV virtual functions while the device is undergoing diagnostic testing\\n\");\n \t\terr = -EPERM;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 9a68c65..9ce4dc9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1555,7 +1555,7 @@ static inline bool i40e_active_vfs(struct i40e_pf *pf)\n \tint i;\n \n \tfor (i = 0; i < pf->num_alloc_vfs; i++)\n-\t\tif (vfs[i].vf_states & I40E_VF_STAT_ACTIVE)\n+\t\tif (test_bit(I40E_VF_STAT_ACTIVE, &vfs[i].vf_states))\n \t\t\treturn true;\n \treturn false;\n }\n", "prefixes": [ "-next" ] }