Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480344/?format=api
{ "id": 480344, "url": "http://patchwork.ozlabs.org/api/patches/480344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604015219.2895.80478.stgit@ahduyck-vm-fedora22/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150604015219.2895.80478.stgit@ahduyck-vm-fedora22>", "list_archive_url": null, "date": "2015-06-04T01:53:17", "name": "fm10k: Fix missing braces after if statement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dda9ea3a5f67e9140cf22ac48678ffe0679ac751", "submitter": { "id": 64958, "url": "http://patchwork.ozlabs.org/api/people/64958/?format=api", "name": "Alexander Duyck", "email": "alexander.h.duyck@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150604015219.2895.80478.stgit@ahduyck-vm-fedora22/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480344/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id F34F0140157\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Jun 2015 11:53:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4272BA1EED;\n\tThu, 4 Jun 2015 01:53:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HfbluPx5kTri; Thu, 4 Jun 2015 01:53:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8CC81A1ED5;\n\tThu, 4 Jun 2015 01:53:21 +0000 (UTC)", "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F0D71C2003\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 01:53:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 66A35A1EE3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 01:53:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uhZg2s9KnFQO for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 01:53:19 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 441CCA1ED5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Jun 2015 01:53:19 +0000 (UTC)", "from int-mx09.intmail.prod.int.phx2.redhat.com\n\t(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3633B345B27;\n\tThu, 4 Jun 2015 01:53:18 +0000 (UTC)", "from [192.168.122.149] (vpn-228-136.phx2.redhat.com [10.3.228.136])\n\tby int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t541rH0G005440; Wed, 3 Jun 2015 21:53:17 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Alexander Duyck <alexander.h.duyck@redhat.com>", "To": "davem@davemloft.net, jeffrey.t.kirsher@intel.com", "Date": "Wed, 03 Jun 2015 18:53:17 -0700", "Message-ID": "<20150604015219.2895.80478.stgit@ahduyck-vm-fedora22>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.22", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if\n\tstatement", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "While reviewing the code I noticed that one of the commits added an if\nstatement followed by a for loop, but the if statement was missing the\nbraces around the loop. This change corrects the coding style error.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex 4b9d9f88af70..a9670e00cf03 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data)\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n \n-\t\tif (interface->hw.mac.type != fm10k_mac_vf)\n+\t\tif (interface->hw.mac.type != fm10k_mac_vf) {\n \t\t\tfor (i = 0; i < FM10K_PF_STATS_LEN; i++) {\n \t\t\t\tmemcpy(p, fm10k_gstrings_pf_stats[i].stat_string,\n \t\t\t\t ETH_GSTRING_LEN);\n \t\t\t\tp += ETH_GSTRING_LEN;\n \t\t\t}\n+\t\t}\n \n \t\tfor (i = 0; i < interface->hw.mac.max_queues; i++) {\n \t\t\tsprintf(p, \"tx_queue_%u_packets\", i);\n", "prefixes": [] }