Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480318/?format=api
{ "id": 480318, "url": "http://patchwork.ozlabs.org/api/patches/480318/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433374272-6684-15-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1433374272-6684-15-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-06-03T23:31:11", "name": "[rc2,14/15] fm10k: remove err_no reference in fm10k_mbx.c", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "31c3102c69dbbe9401df5aa2648c2b13c2e56f78", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433374272-6684-15-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480318/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 9B8B51401EF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Jun 2015 09:31:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BA522328FF;\n\tWed, 3 Jun 2015 23:31:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jwiNy3aiDTPK; Wed, 3 Jun 2015 23:31:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7810732952;\n\tWed, 3 Jun 2015 23:31:25 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8C3561BFA20\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8771D8D175\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NTHF6ZOk2oLn for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E31BF8D1E7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:18 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 03 Jun 2015 16:31:18 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.151])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Jun 2015 16:31:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,549,1427785200\"; d=\"scan'208\";a=\"581683040\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 3 Jun 2015 16:31:11 -0700", "Message-Id": "<1433374272-6684-15-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1433374272-6684-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1433374272-6684-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [rc2 14/15] fm10k: remove err_no reference in\n\tfm10k_mbx.c", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The reference to err_no was left around after a previous code refactor.\nWe never use the value, and it doesn't seem to be used in side a hidden\nmacro reference. Discovered via cppcheck.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\nindex 1b2738380518..1a4b52637de9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n@@ -1259,16 +1259,11 @@ static s32 fm10k_mbx_process_error(struct fm10k_hw *hw,\n \t\t\t\t struct fm10k_mbx_info *mbx)\n {\n \tconst u32 *hdr = &mbx->mbx_hdr;\n-\ts32 err_no;\n \tu16 head;\n \n \t/* we will need to pull all of the fields for verification */\n \thead = FM10K_MSG_HDR_FIELD_GET(*hdr, HEAD);\n \n-\t/* we only have lower 10 bits of error number so add upper bits */\n-\terr_no = FM10K_MSG_HDR_FIELD_GET(*hdr, ERR_NO);\n-\terr_no |= ~FM10K_MSG_HDR_MASK(ERR_NO);\n-\n \tswitch (mbx->state) {\n \tcase FM10K_STATE_OPEN:\n \tcase FM10K_STATE_DISCONNECT:\n", "prefixes": [ "rc2", "14/15" ] }