Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/480311/?format=api
{ "id": 480311, "url": "http://patchwork.ozlabs.org/api/patches/480311/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433374272-6684-16-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1433374272-6684-16-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-06-03T23:31:12", "name": "[rc2,15/15] fm10k: fix iov_msg_lport_state_pf issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8552b54ed867fb23d1690bb9900155377007ae18", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1433374272-6684-16-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/480311/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/480311/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 7FF601402A7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Jun 2015 09:31:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C46F032909;\n\tWed, 3 Jun 2015 23:31:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id n76MVlPLGWJv; Wed, 3 Jun 2015 23:31:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 955363290C;\n\tWed, 3 Jun 2015 23:31:21 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9E6CE1C2C9C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9AD528D188\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AfoLeyz1KAVa for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C6D918D1DC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Jun 2015 23:31:18 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 03 Jun 2015 16:31:18 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.151])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Jun 2015 16:31:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,549,1427785200\"; d=\"scan'208\";a=\"581683041\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 3 Jun 2015 16:31:12 -0700", "Message-Id": "<1433374272-6684-16-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1433374272-6684-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1433374272-6684-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [rc2 15/15] fm10k: fix iov_msg_lport_state_pf\n\tissue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When a VF issues an LPORT_STATE request to enable a port that is already\nenabled, the PF will first disable the VF LPORT. Then it should\nre-enable the VF again with the new requested settings. This ensures\nthat any switch rules are cleared by deleting the LPORT on the switch.\nHowever, the flow is bugged because we actually check if the VF is\nenabled at the end, and thus don't re-enable it. Fix the flow so that we\nactually clear the enabled flags as part of our removal of the LPORT.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex ab81c00327b2..54d1cd97866f 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1351,6 +1351,14 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results,\n \t\t\terr = fm10k_update_lport_state_pf(hw, vf_info->glort,\n \t\t\t\t\t\t\t 1, false);\n \n+\t\t/* we need to clear VF_FLAG_ENABLED flags in order to ensure\n+\t\t * that we actually re-enable the LPORT state below. Note that\n+\t\t * this has no impact if the VF is already disabled, as the\n+\t\t * flags are already cleared.\n+\t\t */\n+\t\tif (!err)\n+\t\t\tvf_info->vf_flags = FM10K_VF_FLAG_CAPABLE(vf_info);\n+\n \t\t/* when enabling the port we should reset the rate limiters */\n \t\thw->iov.ops.configure_tc(hw, vf_info->vf_idx, vf_info->rate);\n \n", "prefixes": [ "rc2", "15/15" ] }