Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/475735/?format=api
{ "id": 475735, "url": "http://patchwork.ozlabs.org/api/patches/475735/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150522174950.16145.78447.stgit@htfujina-fc.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150522174950.16145.78447.stgit@htfujina-fc.jf.intel.com>", "list_archive_url": null, "date": "2015-05-22T17:49:50", "name": "igb: report unsupported ethtool settings in set_coalesce", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "07c93e96bd54048ba0434951ec780a78f2b673f9", "submitter": { "id": 29211, "url": "http://patchwork.ozlabs.org/api/people/29211/?format=api", "name": "Fujinaka, Todd", "email": "todd.fujinaka@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150522174950.16145.78447.stgit@htfujina-fc.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/475735/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/475735/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 27789140E33\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 May 2015 03:51:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CAB0893D30;\n\tFri, 22 May 2015 17:51:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YxowtEMqNs2p; Fri, 22 May 2015 17:51:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5D3CD93192;\n\tFri, 22 May 2015 17:51:30 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DABA11C0C9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 May 2015 17:51:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DD5DD8BF6D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 May 2015 17:51:28 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XpNbm9e3VQ1P for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 May 2015 17:51:28 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4281B8BF67\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 May 2015 17:51:28 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 22 May 2015 10:51:26 -0700", "from htfujina-fc.jf.intel.com ([134.134.145.52])\n\tby orsmga002.jf.intel.com with ESMTP; 22 May 2015 10:51:26 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,477,1427785200\"; d=\"scan'208\";a=\"733864197\"", "From": "Todd Fujinaka <todd.fujinaka@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 22 May 2015 10:49:50 -0700", "Message-ID": "<20150522174950.16145.78447.stgit@htfujina-fc.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] igb: report unsupported ethtool settings\n\tin set_coalesce", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "There are many settings possible using ethtool -C/--coalesce, but not\nall of them are supported. Report failure when an unsupported option is\nset.\n\nSigned-off-by: Todd Fujinaka <todd.fujinaka@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 109cad9..13560fe 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2159,6 +2159,27 @@ static int igb_set_coalesce(struct net_device *netdev,\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n \tint i;\n \n+\tif ((ec->rx_max_coalesced_frames != -1) ||\n+\t (ec->rx_coalesce_usecs_irq != -1) ||\n+\t (ec->rx_max_coalesced_frames_irq != -1) ||\n+\t (ec->tx_max_coalesced_frames != -1) ||\n+\t (ec->tx_coalesce_usecs_irq != -1) ||\n+\t (ec->stats_block_coalesce_usecs != -1) ||\n+\t (ec->use_adaptive_rx_coalesce != -1) ||\n+\t (ec->use_adaptive_tx_coalesce != -1) ||\n+\t (ec->pkt_rate_low != -1) ||\n+\t (ec->rx_coalesce_usecs_low != -1) ||\n+\t (ec->rx_max_coalesced_frames_low != -1) ||\n+\t (ec->tx_coalesce_usecs_low != -1) ||\n+\t (ec->tx_max_coalesced_frames_low != -1) ||\n+\t (ec->pkt_rate_high != -1) ||\n+\t (ec->rx_coalesce_usecs_high != -1) ||\n+\t (ec->rx_max_coalesced_frames_high != -1) ||\n+\t (ec->tx_coalesce_usecs_high != -1) ||\n+\t (ec->tx_max_coalesced_frames_high != -1) ||\n+\t (ec->rate_sample_interval != -1))\n+\t\treturn -ENOTSUPP;\n+\n \tif ((ec->rx_coalesce_usecs > IGB_MAX_ITR_USECS) ||\n \t ((ec->rx_coalesce_usecs > 3) &&\n \t (ec->rx_coalesce_usecs < IGB_MIN_ITR_USECS)) ||\n", "prefixes": [] }