Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/466320/?format=api
{ "id": 466320, "url": "http://patchwork.ozlabs.org/api/patches/466320/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150429222328.18201.67366.stgit@htfujina-fc.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150429222328.18201.67366.stgit@htfujina-fc.jf.intel.com>", "list_archive_url": null, "date": "2015-04-29T22:23:28", "name": "igb: Fix i354 88E1112 PHY on RCC boards using AutoMediaDetect", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "efe0d321851e12394661edcf717f32a55373ef0e", "submitter": { "id": 29211, "url": "http://patchwork.ozlabs.org/api/people/29211/?format=api", "name": "Fujinaka, Todd", "email": "todd.fujinaka@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150429222328.18201.67366.stgit@htfujina-fc.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/466320/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/466320/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 33D011402BC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Apr 2015 08:25:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 66D3695D93;\n\tWed, 29 Apr 2015 22:25:16 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y6cW8AUMEVIA; Wed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D0A2795D8C;\n\tWed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 72A351C214E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6BB5B9172B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pP2FDK82MqsS for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 13EB291732\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 Apr 2015 22:25:15 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 29 Apr 2015 15:25:15 -0700", "from htfujina-fc.jf.intel.com ([134.134.145.123])\n\tby orsmga002.jf.intel.com with ESMTP; 29 Apr 2015 15:25:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,672,1422950400\"; d=\"scan'208\";a=\"721307750\"", "From": "Todd Fujinaka <todd.fujinaka@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 29 Apr 2015 15:23:28 -0700", "Message-ID": "<20150429222328.18201.67366.stgit@htfujina-fc.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] igb: Fix i354 88E1112 PHY on RCC boards\n\tusing AutoMediaDetect", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "e1000_check_for_link_media_swap() checks PHY page 0 for copper and PHY\npage 1 for \"other\" (fiber) link. The switch back from page 1 to page 0\nhappened too soon, before e1000_check_for_link_82575() is executed, and\nlink on fiber (other) was never detected. Check for link while still on\nthe proper PHY page.\n\nSigned-off-by: Todd Fujinaka <todd.fujinaka@intel.com>\n---\n drivers/net/ethernet/intel/igb/e1000_82575.c | 18 +++++++++++++-----\n 1 file changed, 13 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c\nindex b0182dd..d192569 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c\n@@ -139,10 +139,6 @@ static s32 igb_check_for_link_media_swap(struct e1000_hw *hw)\n \tif (ret_val)\n \t\treturn ret_val;\n \n-\t/* reset page to 0 */\n-\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n-\tif (ret_val)\n-\t\treturn ret_val;\n \n \tif (data & E1000_M88E1112_STATUS_LINK)\n \t\tport = E1000_MEDIA_PORT_OTHER;\n@@ -151,8 +147,20 @@ static s32 igb_check_for_link_media_swap(struct e1000_hw *hw)\n \tif (port && (hw->dev_spec._82575.media_port != port)) {\n \t\thw->dev_spec._82575.media_port = port;\n \t\thw->dev_spec._82575.media_changed = true;\n+\t}\n+\n+\tif (port == E1000_MEDIA_PORT_COPPER) {\n+\t\t/* reset page to 0 */\n+\t\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n+\t\tif (ret_val)\n+\t\t\treturn ret_val;\n+\t\tigb_check_for_link_82575(hw);\n \t} else {\n-\t\tret_val = igb_check_for_link_82575(hw);\n+\t\tigb_check_for_link_82575(hw);\n+\t\t/* reset page to 0 */\n+\t\tret_val = phy->ops.write_reg(hw, E1000_M88E1112_PAGE_ADDR, 0);\n+\t\tif (ret_val)\n+\t\t\treturn ret_val;\n \t}\n \n \treturn 0;\n", "prefixes": [] }