Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/465195/?format=api
{ "id": 465195, "url": "http://patchwork.ozlabs.org/api/patches/465195/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1430161042-28494-11-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1430161042-28494-11-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-04-27T18:57:17", "name": "[net-next,S5,10/15] i40evf: add MAC address filter in open, not init", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bf2cdbc5d3305fb95ea867623f052905e838e430", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1430161042-28494-11-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/465195/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/465195/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id E20591400DE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 28 Apr 2015 04:54:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3CBBFA12B4;\n\tMon, 27 Apr 2015 18:54:53 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VvRZEFbms3RE; Mon, 27 Apr 2015 18:54:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EE331A12C0;\n\tMon, 27 Apr 2015 18:54:51 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 866121C21C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 820D68B8E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:50 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ursz+gYFV4Hi for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:50 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 20E9D8B8CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:50 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Apr 2015 11:54:50 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2015 11:54:49 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,658,1422950400\"; d=\"scan'208\";a=\"486315511\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 27 Apr 2015 14:57:17 -0400", "Message-Id": "<1430161042-28494-11-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1430161042-28494-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1430161042-28494-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [net-next S5 10/15] i40evf: add MAC address\n\tfilter in open, not init", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nDuring close, all of the MAC filters are cleared, so the driver would be\nunable to receive unicast packets after being closed and reopened.\n\nAdd the adapter's \"hardware\" MAC address filter in open, not init. This\nensures that the correct filter is present each time.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I51a11e9c1200139dab6f66a5353bd38c7d26f875\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 12 +-----------\n 1 file changed, 1 insertion(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex a519c05..0f6ea56f 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1835,6 +1835,7 @@ static int i40evf_open(struct net_device *netdev)\n \tif (err)\n \t\tgoto err_req_irq;\n \n+\ti40evf_add_filter(adapter, adapter->hw.mac.addr);\n \ti40evf_configure(adapter);\n \n \terr = i40evf_up_complete(adapter);\n@@ -2015,7 +2016,6 @@ static void i40evf_init_task(struct work_struct *work)\n \t\t\t\t\t\t struct i40evf_adapter,\n \t\t\t\t\t\t init_task.work);\n \tstruct net_device *netdev = adapter->netdev;\n-\tstruct i40evf_mac_filter *f;\n \tstruct i40e_hw *hw = &adapter->hw;\n \tstruct pci_dev *pdev = adapter->pdev;\n \tint i, err, bufsz;\n@@ -2149,16 +2149,6 @@ static void i40evf_init_task(struct work_struct *work)\n \tether_addr_copy(netdev->dev_addr, adapter->hw.mac.addr);\n \tether_addr_copy(netdev->perm_addr, adapter->hw.mac.addr);\n \n-\tf = kzalloc(sizeof(*f), GFP_ATOMIC);\n-\tif (!f)\n-\t\tgoto err_sw_init;\n-\n-\tether_addr_copy(f->macaddr, adapter->hw.mac.addr);\n-\tf->add = true;\n-\tadapter->aq_required |= I40EVF_FLAG_AQ_ADD_MAC_FILTER;\n-\n-\tlist_add(&f->list, &adapter->mac_filter_list);\n-\n \tinit_timer(&adapter->watchdog_timer);\n \tadapter->watchdog_timer.function = &i40evf_watchdog_timer;\n \tadapter->watchdog_timer.data = (unsigned long)adapter;\n", "prefixes": [ "net-next", "S5", "10/15" ] }