Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/465190/?format=api
{ "id": 465190, "url": "http://patchwork.ozlabs.org/api/patches/465190/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1430161042-28494-7-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1430161042-28494-7-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-04-27T18:57:13", "name": "[net-next,S5,06/15] i40e: correctly program filters for VFs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dcee65919336646baeb1e2a1e71d147449a0b9fc", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1430161042-28494-7-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/465190/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/465190/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 8A17414007D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 28 Apr 2015 04:54:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DE20394E86;\n\tMon, 27 Apr 2015 18:54:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WTQ7MINHS09W; Mon, 27 Apr 2015 18:54:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 71CFE94E8C;\n\tMon, 27 Apr 2015 18:54:48 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 676081C21C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 63B208B8CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id p-0LYOw050sC for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:47 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E75E28B8E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Apr 2015 18:54:46 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Apr 2015 11:54:46 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2015 11:54:46 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,658,1422950400\"; d=\"scan'208\";a=\"486315482\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 27 Apr 2015 14:57:13 -0400", "Message-Id": "<1430161042-28494-7-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1430161042-28494-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1430161042-28494-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [net-next S5 06/15] i40e: correctly program\n\tfilters for VFs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nMAC filters for VFs were being programmed with 0 for the VLAN value when\nthere was no VLAN assigned. This is incorrect and actually assigns the\nVF to VLAN 0. Instead, we must use -1 to indicate that no VLAN is in\nuse. This change programs the filters correctly and gets rid of a bogus\nerror message when setting a port VLAN on an active VF.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: Ica9a9906d768405377ff3308e27f7d0b5b2ea96e\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex e6ab8ee..5c7af7d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -542,11 +542,13 @@ static int i40e_alloc_vsi_res(struct i40e_vf *vf, enum i40e_vsi_type type)\n \t\tif (vf->port_vlan_id)\n \t\t\ti40e_vsi_add_pvid(vsi, vf->port_vlan_id);\n \t\tf = i40e_add_filter(vsi, vf->default_lan_addr.addr,\n-\t\t\t\t vf->port_vlan_id, true, false);\n+\t\t\t\t vf->port_vlan_id ? vf->port_vlan_id : -1,\n+\t\t\t\t true, false);\n \t\tif (!f)\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"Could not allocate VF MAC addr\\n\");\n-\t\tf = i40e_add_filter(vsi, brdcast, vf->port_vlan_id,\n+\t\tf = i40e_add_filter(vsi, brdcast,\n+\t\t\t\t vf->port_vlan_id ? vf->port_vlan_id : -1,\n \t\t\t\t true, false);\n \t\tif (!f)\n \t\t\tdev_info(&pf->pdev->dev,\n@@ -2015,7 +2017,8 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \t}\n \n \t/* delete the temporary mac address */\n-\ti40e_del_filter(vsi, vf->default_lan_addr.addr, vf->port_vlan_id,\n+\ti40e_del_filter(vsi, vf->default_lan_addr.addr,\n+\t\t\tvf->port_vlan_id ? vf->port_vlan_id : -1,\n \t\t\ttrue, false);\n \n \t/* Delete all the filters for this VSI - we're going to kill it\n", "prefixes": [ "net-next", "S5", "06/15" ] }