Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/463808/?format=api
{ "id": 463808, "url": "http://patchwork.ozlabs.org/api/patches/463808/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429738837-25158-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429738837-25158-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2015-04-22T21:40:30", "name": "[1/8] clarify implementation of ethtool's get_ts_info op", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "45cf18d812ad8c75f2f3a24d5342eb0ab20c04f3", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429738837-25158-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/463808/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/463808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id E5E82140133\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Apr 2015 07:41:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 74AABA15D7;\n\tWed, 22 Apr 2015 21:41:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OZHshyqFY8zo; Wed, 22 Apr 2015 21:41:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 707D4A15DF;\n\tWed, 22 Apr 2015 21:41:00 +0000 (UTC)", "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id A6BA01C28AC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 21:40:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C24D9A15AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 21:40:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ptdWhl6ivrhc for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 21:40:51 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B36E3A1589\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 21:40:51 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 22 Apr 2015 14:40:51 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.151])\n\tby fmsmga001.fm.intel.com with ESMTP; 22 Apr 2015 14:40:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,626,1422950400\"; d=\"scan'208\";a=\"699410684\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Apr 2015 14:40:30 -0700", "Message-Id": "<1429738837-25158-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [PATCH 1/8] clarify implementation of ethtool's\n\tget_ts_info op", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch adds some clarification about the intended way to implement\nboth SIOCSHWTSTAMP and ethtool's get_ts_info. The HWTSTAMP API has\nseveral Rx filters which are very specific, as well as more general\nfilters. The specific filters really only exist to support some broken\nhardware which can't fully implement the generic filters. This patch\nadds clarification that it is okay to support the specific filters in\nSIOCSHWTSTAMP by upscaling them to the generic filters. In addition,\nupdate the header for ethtool_ts_info to specify that drivers ought to\nonly report the filters they support without upscaling in this manner.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n Documentation/networking/timestamping.txt | 7 +++++++\n include/uapi/linux/ethtool.h | 5 +++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/Documentation/networking/timestamping.txt b/Documentation/networking/timestamping.txt\nindex 5f0922613f1a..a977339fbe0a 100644\n--- a/Documentation/networking/timestamping.txt\n+++ b/Documentation/networking/timestamping.txt\n@@ -359,6 +359,13 @@ the requested fine-grained filtering for incoming packets is not\n supported, the driver may time stamp more than just the requested types\n of packets.\n \n+Drivers are free to use a more permissive configuration than the requested\n+configuration. It is expected that drivers should only implement directly the\n+most generic mode that can be supported. For example if the hardware can\n+support HWTSTAMP_FILTER_V2_EVENT, then it should generally always upscale\n+HWTSTAMP_FILTER_V2_L2_SYNC_MESSAGE, and so forth, as HWTSTAMP_FILTER_V2_EVENT\n+is more generic (and more useful to applications).\n+\n A driver which supports hardware time stamping shall update the struct\n with the actual, possibly more permissive configuration. If the\n requested packets cannot be time stamped, then nothing should be\ndiff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h\nindex 2e49fc880d29..c1e1d9a001ba 100644\n--- a/include/uapi/linux/ethtool.h\n+++ b/include/uapi/linux/ethtool.h\n@@ -1062,6 +1062,11 @@ struct ethtool_sfeatures {\n * the 'hwtstamp_tx_types' and 'hwtstamp_rx_filters' enumeration values,\n * respectively. For example, if the device supports HWTSTAMP_TX_ON,\n * then (1 << HWTSTAMP_TX_ON) in 'tx_types' will be set.\n+ *\n+ * Drivers should only report the filters they actually support without\n+ * upscaling in the SIOCSHWTSTAMP ioctl. If the SIOCSHWSTAMP request for\n+ * HWTSTAMP_FILTER_V1_SYNC is supported by HWTSTAMP_FILTER_V1_EVENT, then the\n+ * driver should only report HWTSTAMP_FILTER_V1_EVENT in this op.\n */\n struct ethtool_ts_info {\n \t__u32\tcmd;\n", "prefixes": [ "1/8" ] }