Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/463702/?format=api
{ "id": 463702, "url": "http://patchwork.ozlabs.org/api/patches/463702/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429719917-25985-1-git-send-email-yanirx.lubetkin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429719917-25985-1-git-send-email-yanirx.lubetkin@intel.com>", "list_archive_url": null, "date": "2015-04-22T16:25:17", "name": "e1000e: fix logical error in flush_desc_rings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9f107ab8e8996559a7f551b101e66690dfd072b7", "submitter": { "id": 66154, "url": "http://patchwork.ozlabs.org/api/people/66154/?format=api", "name": "Yanir Lubetkin", "email": "yanirx.lubetkin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429719917-25985-1-git-send-email-yanirx.lubetkin@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/463702/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/463702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 8AE46140133\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Apr 2015 02:25:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A6E8932DEE;\n\tWed, 22 Apr 2015 16:25:27 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id siYOvN2klN8k; Wed, 22 Apr 2015 16:25:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3F29232C43;\n\tWed, 22 Apr 2015 16:25:26 +0000 (UTC)", "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id F2AEF1C107C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 16:25:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EEE8BA1269\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 16:25:24 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q93u3nP3-Qw7 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 16:25:24 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 69FFBA121A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 16:25:24 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 22 Apr 2015 09:25:24 -0700", "from unknown (HELO ccdskly16.iil.intel.com) ([143.185.160.82])\n\tby fmsmga002.fm.intel.com with ESMTP; 22 Apr 2015 09:25:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,624,1422950400\"; d=\"scan'208\";a=\"713679681\"", "From": "Yanir Lubetkin <yanirx.lubetkin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Apr 2015 19:25:17 +0300", "Message-Id": "<1429719917-25985-1-git-send-email-yanirx.lubetkin@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [PATCH] e1000e: fix logical error in\n\tflush_desc_rings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "the condition under which the flush should occur was reversed.\nThe fix should be applied before any HW reset (unless followed by bus reset)\nand before any power state transition from D0.\nif E1000_FEXTNVM7_NEED_DESCRING_FLUSH bit is set in FEXTNVM7 and TDLEN > 0\nthe tx ring should be flushed. (fixes ~95% of the hang states).\nif the E1000_FEXTNVM7_NEED_DESCRING_FLUSH did not clear, we should also\nflush the RX ring. Bug was caught by Alexander Duyck during a code review\nwhen examining this fix.\n\nSigned-off-by: Yanir Lubetkin <yanirx.lubetkin@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 76b1a90..de8caf4 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3878,7 +3878,7 @@ static void e1000_flush_desc_rings(struct e1000_adapter *adapter)\n \t/* do nothing if we're not in faulty state, or if the queue is empty */\n \ttdlen = er32(TDLEN(0));\n \thang_state = er32(FEXTNVM7);\n-\tif ((hang_state & E1000_FEXTNVM7_NEED_DESCRING_FLUSH) || tdlen)\n+\tif (!(hang_state & E1000_FEXTNVM7_NEED_DESCRING_FLUSH) || !tdlen)\n \t\treturn;\n \te1000_flush_tx_ring(adapter);\n \t/* recheck, maybe the fault is caused by the rx ring */\n", "prefixes": [] }