Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/463550/?format=api
{ "id": 463550, "url": "http://patchwork.ozlabs.org/api/patches/463550/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429671343-13453-1-git-send-email-yanirx.lubetkin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429671343-13453-1-git-send-email-yanirx.lubetkin@intel.com>", "list_archive_url": null, "date": "2015-04-22T02:55:43", "name": "e1000e: remove call to do_div and sign mismatch warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e661aed28cd63c5b618df8f8c97d16431888ee56", "submitter": { "id": 66154, "url": "http://patchwork.ozlabs.org/api/people/66154/?format=api", "name": "Yanir Lubetkin", "email": "yanirx.lubetkin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429671343-13453-1-git-send-email-yanirx.lubetkin@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/463550/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/463550/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3FD3C1401AD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Apr 2015 12:55:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5682E302CD;\n\tWed, 22 Apr 2015 02:55:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iEd+CJjXgzBu; Wed, 22 Apr 2015 02:55:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C4C24303E6;\n\tWed, 22 Apr 2015 02:55:52 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 209031C2248\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 02:55:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 180678AEB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 02:55:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x3WvuWkvxtCb for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 02:55:49 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C54CA8AEB3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 02:55:49 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 21 Apr 2015 19:55:49 -0700", "from unknown (HELO ccdskly16.iil.intel.com) ([143.185.160.82])\n\tby FMSMGA003.fm.intel.com with ESMTP; 21 Apr 2015 19:55:49 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,620,1422950400\"; d=\"scan'208\";a=\"483979097\"", "From": "Yanir Lubetkin <yanirx.lubetkin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Apr 2015 05:55:43 +0300", "Message-Id": "<1429671343-13453-1-git-send-email-yanirx.lubetkin@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [PATCH] e1000e: remove call to do_div and sign\n\tmismatch warning", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "fixes a warning that was reported by Yanjiang Jin <yanjiang.jin@windriver.com>\nby implementing the solution suggested by\nAlexander Duyck <alexander.h.duyck@redhat.com>.\n\nSigned-off-by: Yanir Lubetkin <yanirx.lubetkin@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex e18443a..b8b0900 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1014,7 +1014,6 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)\n \t\tu16 speed, duplex, scale = 0;\n \t\tu16 max_snoop, max_nosnoop;\n \t\tu16 max_ltr_enc;\t/* max LTR latency encoded */\n-\t\ts64 lat_ns;\t/* latency (ns) */\n \t\tu64 value;\n \t\tu32 rxa;\n \n@@ -1040,14 +1039,9 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)\n \t\t * 2^25*(2^10-1) ns. The scale is encoded as 0=2^0ns,\n \t\t * 1=2^5ns, 2=2^10ns,...5=2^25ns.\n \t\t */\n-\t\tlat_ns = ((s64)rxa * 1024 -\n-\t\t\t (2 * (s64)hw->adapter->max_frame_size)) * 8 * 1000;\n-\t\tif (lat_ns < 0) {\n-\t\t\tvalue = 0;\n-\t\t} else {\n-\t\t\tvalue = lat_ns;\n-\t\t\tdo_div(value, speed);\n-\t\t}\n+\t\trxa *= 512;\n+\t\tvalue = (rxa > hw->adapter->max_frame_size) ?\n+\t\t\t(rxa - hw->adapter->max_frame_size) * (16000 / speed) : 0;\n \n \t\twhile (value > PCI_LTR_VALUE_MASK) {\n \t\t\tscale++;\n", "prefixes": [] }