Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/463537/?format=api
{ "id": 463537, "url": "http://patchwork.ozlabs.org/api/patches/463537/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429665301-10596-1-git-send-email-yanirx.lubetkin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429665301-10596-1-git-send-email-yanirx.lubetkin@intel.com>", "list_archive_url": null, "date": "2015-04-22T01:15:01", "name": "e1000e: i219 execute unit hang fix on every reset or power state transition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a6fc9381503496ecb2b19c928007ca5f59a28813", "submitter": { "id": 66154, "url": "http://patchwork.ozlabs.org/api/people/66154/?format=api", "name": "Yanir Lubetkin", "email": "yanirx.lubetkin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429665301-10596-1-git-send-email-yanirx.lubetkin@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/463537/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/463537/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id F269514010F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Apr 2015 11:15:10 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 129A393391;\n\tWed, 22 Apr 2015 01:15:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Hx6nNB6fSvEB; Wed, 22 Apr 2015 01:15:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 69D9C9338F;\n\tWed, 22 Apr 2015 01:15:09 +0000 (UTC)", "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BF3B31C0505\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 01:15:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B89D72EE26\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 01:15:08 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vGehDilbk3x8 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 01:15:07 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id BCC552EBEA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Apr 2015 01:15:07 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 21 Apr 2015 18:15:07 -0700", "from unknown (HELO ccdskly16.iil.intel.com) ([143.185.160.82])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Apr 2015 18:15:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,620,1422950400\"; d=\"scan'208\";a=\"713275614\"", "From": "Yanir Lubetkin <yanirx.lubetkin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Apr 2015 04:15:01 +0300", "Message-Id": "<1429665301-10596-1-git-send-email-yanirx.lubetkin@intel.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[Intel-wired-lan] [PATCH] e1000e: i219 execute unit hang fix on\n\tevery reset or power state transition", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "after testing various cases, the conclusion is that the fix MUST be executed BEFORE\nany event that the HW is reset or transition to D3. to fix that I moved the execution\nto the relevant places but per Alexander Duyck's review, ensure now that the DMA is\nvalid and was not freed before manipulating the ring.\n\nSigned-off-by: Yanir Lubetkin <yanirx.lubetkin@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 76b1a90..3f561f3 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -4043,6 +4043,8 @@ void e1000e_reset(struct e1000_adapter *adapter)\n \t\t}\n \t}\n \n+\tif (hw->mac.type == e1000_pch_spt)\n+\t\te1000_flush_desc_rings(adapter);\n \t/* Allow time for pending master requests to run */\n \tmac->ops.reset_hw(hw);\n \n@@ -4215,10 +4217,6 @@ void e1000e_down(struct e1000_adapter *adapter, bool reset)\n \tspin_unlock(&adapter->stats64_lock);\n \n \te1000e_flush_descriptors(adapter);\n-\tif (hw->mac.type == e1000_pch_spt)\n-\t\te1000_flush_desc_rings(adapter);\n-\te1000_clean_tx_ring(adapter->tx_ring);\n-\te1000_clean_rx_ring(adapter->rx_ring);\n \n \tadapter->link_speed = 0;\n \tadapter->link_duplex = 0;\n@@ -4229,8 +4227,14 @@ void e1000e_down(struct e1000_adapter *adapter, bool reset)\n \t e1000_lv_jumbo_workaround_ich8lan(hw, false))\n \t\te_dbg(\"failed to disable jumbo frame workaround mode\\n\");\n \n-\tif (reset && !pci_channel_offline(adapter->pdev))\n-\t\te1000e_reset(adapter);\n+ if (!pci_channel_offline(adapter->pdev)) {\n+ if(reset)\n+ e1000e_reset(adapter);\n+ else if (hw->mac.type == e1000_pch_spt)\n+ e1000_flush_desc_rings(adapter);\n+ }\n+\te1000_clean_tx_ring(adapter->tx_ring);\n+\te1000_clean_rx_ring(adapter->rx_ring);\n }\n \n void e1000e_reinit_locked(struct e1000_adapter *adapter)\n", "prefixes": [] }