Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/461897/?format=api
{ "id": 461897, "url": "http://patchwork.ozlabs.org/api/patches/461897/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429229172-143692-15-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429229172-143692-15-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-04-17T00:06:11", "name": "[net-next,S4,14/15] i40e/i40evf: remove time_stamp member", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e19dc1d00a7a89300b358e9b907fb3796c08b1c2", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429229172-143692-15-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/461897/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/461897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id B8EA31402A6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 17 Apr 2015 10:04:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 155F18B075;\n\tFri, 17 Apr 2015 00:04:08 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TJfC5coyFULb; Fri, 17 Apr 2015 00:04:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 115978B074;\n\tFri, 17 Apr 2015 00:04:06 +0000 (UTC)", "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 575871C2990\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:04:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5377189E94\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:04:04 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HFZ30Yap93OU for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:04:03 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 36F3589E8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:04:03 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Apr 2015 17:03:30 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 16 Apr 2015 17:03:30 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,591,1422950400\"; d=\"scan'208\";a=\"481989733\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 16 Apr 2015 20:06:11 -0400", "Message-Id": "<1429229172-143692-15-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1429229172-143692-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1429229172-143692-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [net-next S4 14/15] i40e/i40evf: remove\n\ttime_stamp member", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver doesn't use the time_stamp member to determine if there is a\ntx_hang any more. There really isn't any point to the variable at all\nso just remove it. It was left over from a previous tx_hang design.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I4c814827e1bcb46e45118fe37acdcfa814fb62a0\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 10 ----------\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 -\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 7 -------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 1 -\n 4 files changed, 19 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex ca21f9a..e1596dc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -165,9 +165,6 @@ int i40e_program_fdir_filter(struct i40e_fdir_filter *fdir_data, u8 *raw_packet,\n \ttx_desc->cmd_type_offset_bsz =\n \t\tbuild_ctob(td_cmd, 0, I40E_FDIR_MAX_RAW_PACKET_SIZE, 0);\n \n-\t/* set the timestamp */\n-\ttx_buf->time_stamp = jiffies;\n-\n \t/* Force memory writes to complete before letting h/w\n \t * know there are new descriptors to fetch.\n \t */\n@@ -810,10 +807,6 @@ static bool i40e_clean_tx_irq(struct i40e_ring *tx_ring, int budget)\n \t\t\t tx_ring->vsi->seid,\n \t\t\t tx_ring->queue_index,\n \t\t\t tx_ring->next_to_use, i);\n-\t\tdev_info(tx_ring->dev, \"tx_bi[next_to_clean]\\n\"\n-\t\t\t \" time_stamp <%lx>\\n\"\n-\t\t\t \" jiffies <%lx>\\n\",\n-\t\t\t tx_ring->tx_bi[i].time_stamp, jiffies);\n \n \t\tnetif_stop_subqueue(tx_ring->netdev, tx_ring->queue_index);\n \n@@ -2608,9 +2601,6 @@ static inline void i40e_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \t\t\t\t\t\t tx_ring->queue_index),\n \t\t\t first->bytecount);\n \n-\t/* set the timestamp */\n-\tfirst->time_stamp = jiffies;\n-\n \t/* Force memory writes to complete before letting h/w\n \t * know there are new descriptors to fetch. (Only\n \t * applicable for weak-ordered memory model archs,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex ea1df3b..0dc48dc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -147,7 +147,6 @@ enum i40e_dyn_idx_t {\n \n struct i40e_tx_buffer {\n \tstruct i40e_tx_desc *next_to_watch;\n-\tunsigned long time_stamp;\n \tunion {\n \t\tstruct sk_buff *skb;\n \t\tvoid *raw_buf;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex fa2458b..11de5a5 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -322,10 +322,6 @@ static bool i40e_clean_tx_irq(struct i40e_ring *tx_ring, int budget)\n \t\t\t tx_ring->vsi->seid,\n \t\t\t tx_ring->queue_index,\n \t\t\t tx_ring->next_to_use, i);\n-\t\tdev_info(tx_ring->dev, \"tx_bi[next_to_clean]\\n\"\n-\t\t\t \" time_stamp <%lx>\\n\"\n-\t\t\t \" jiffies <%lx>\\n\",\n-\t\t\t tx_ring->tx_bi[i].time_stamp, jiffies);\n \n \t\tnetif_stop_subqueue(tx_ring->netdev, tx_ring->queue_index);\n \n@@ -1826,9 +1822,6 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \t\t\t\t\t\t tx_ring->queue_index),\n \t\t\t first->bytecount);\n \n-\t/* set the timestamp */\n-\tfirst->time_stamp = jiffies;\n-\n \t/* Force memory writes to complete before letting h/w\n \t * know there are new descriptors to fetch. (Only\n \t * applicable for weak-ordered memory model archs,\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\nindex a23f5e8..e7a34f8 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n@@ -146,7 +146,6 @@ enum i40e_dyn_idx_t {\n \n struct i40e_tx_buffer {\n \tstruct i40e_tx_desc *next_to_watch;\n-\tunsigned long time_stamp;\n \tunion {\n \t\tstruct sk_buff *skb;\n \t\tvoid *raw_buf;\n", "prefixes": [ "net-next", "S4", "14/15" ] }