Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/461891/?format=api
{ "id": 461891, "url": "http://patchwork.ozlabs.org/api/patches/461891/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429229172-143692-10-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1429229172-143692-10-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-04-17T00:06:06", "name": "[net-next,S4,09/15] i40e: Move the FD ATR/SB messages to a higher debug level", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ec59b17abb2154294fb5f95a9c4d9bf55314a9c", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1429229172-143692-10-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/461891/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/461891/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 49E981402A6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 17 Apr 2015 10:03:23 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9F68589E98;\n\tFri, 17 Apr 2015 00:03:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QZ1fz6eic0Ps; Fri, 17 Apr 2015 00:03:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2724C89E91;\n\tFri, 17 Apr 2015 00:03:22 +0000 (UTC)", "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id C5B201C223A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:03:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C1C0C89E85\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:03:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IwGFd5W-2Wjn for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:03:20 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3484189E6E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Apr 2015 00:03:20 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Apr 2015 17:03:20 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 16 Apr 2015 17:03:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,591,1422950400\"; d=\"scan'208\";a=\"481989678\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 16 Apr 2015 20:06:06 -0400", "Message-Id": "<1429229172-143692-10-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1429229172-143692-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1429229172-143692-1-git-send-email-catherine.sullivan@intel.com>", "Cc": "Anjali Singhai Jain <anjali.singhai@intel.com>", "Subject": "[Intel-wired-lan] [net-next S4 09/15] i40e: Move the FD ATR/SB\n\tmessages to a higher debug level", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nThese are not useful unless SV is happening as there is a FD flush counter\nthat tracks this.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nChange-ID: If2655b5a29687247d03a51d35f69854bbeb711ce\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 18 ++++++++++++------\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ++++++---\n 2 files changed, 18 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex a5c13de..567303e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4744,7 +4744,8 @@ static int i40e_up_complete(struct i40e_vsi *vsi)\n \t\tpf->fd_add_err = pf->fd_atr_cnt = 0;\n \t\tif (pf->fd_tcp_rule > 0) {\n \t\t\tpf->flags &= ~I40E_FLAG_FD_ATR_ENABLED;\n-\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 exist\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 exist\\n\");\n \t\t\tpf->fd_tcp_rule = 0;\n \t\t}\n \t\ti40e_fdir_filter_restore(vsi);\n@@ -5433,7 +5434,8 @@ void i40e_fdir_check_and_reenable(struct i40e_pf *pf)\n \t\tif ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&\n \t\t (pf->auto_disable_flags & I40E_FLAG_FD_SB_ENABLED)) {\n \t\t\tpf->auto_disable_flags &= ~I40E_FLAG_FD_SB_ENABLED;\n-\t\t\tdev_info(&pf->pdev->dev, \"FD Sideband/ntuple is being enabled since we have space in the table now\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"FD Sideband/ntuple is being enabled since we have space in the table now\\n\");\n \t\t}\n \t}\n \t/* Wait for some more space to be available to turn on ATR */\n@@ -5441,7 +5443,8 @@ void i40e_fdir_check_and_reenable(struct i40e_pf *pf)\n \t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n \t\t (pf->auto_disable_flags & I40E_FLAG_FD_ATR_ENABLED)) {\n \t\t\tpf->auto_disable_flags &= ~I40E_FLAG_FD_ATR_ENABLED;\n-\t\t\tdev_info(&pf->pdev->dev, \"ATR is being enabled since we have space in the table now\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"ATR is being enabled since we have space in the table now\\n\");\n \t\t}\n \t}\n }\n@@ -5474,7 +5477,8 @@ static void i40e_fdir_flush_and_replay(struct i40e_pf *pf)\n \n \t\tif (!(time_after(jiffies, min_flush_time)) &&\n \t\t (fd_room < I40E_FDIR_BUFFER_HEAD_ROOM_FOR_ATR)) {\n-\t\t\tdev_info(&pf->pdev->dev, \"ATR disabled, not enough FD filter space.\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"ATR disabled, not enough FD filter space.\\n\");\n \t\t\tdisable_atr = true;\n \t\t}\n \n@@ -5501,7 +5505,8 @@ static void i40e_fdir_flush_and_replay(struct i40e_pf *pf)\n \t\t\tif (!disable_atr)\n \t\t\t\tpf->flags |= I40E_FLAG_FD_ATR_ENABLED;\n \t\t\tclear_bit(__I40E_FD_FLUSH_REQUESTED, &pf->state);\n-\t\t\tdev_info(&pf->pdev->dev, \"FD Filter table flushed and FD-SB replayed.\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"FD Filter table flushed and FD-SB replayed.\\n\");\n \t\t}\n \t}\n }\n@@ -7772,7 +7777,8 @@ bool i40e_set_ntuple(struct i40e_pf *pf, netdev_features_t features)\n \t\tpf->fd_add_err = pf->fd_atr_cnt = pf->fd_tcp_rule = 0;\n \t\tpf->fdir_pf_active_filters = 0;\n \t\tpf->flags |= I40E_FLAG_FD_ATR_ENABLED;\n-\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled.\\n\");\n+\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled.\\n\");\n \t\t/* if ATR was auto disabled it can be re-enabled. */\n \t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n \t\t (pf->auto_disable_flags & I40E_FLAG_FD_ATR_ENABLED))\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex d781a86..d6ad42b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -283,7 +283,8 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,\n \tif (add) {\n \t\tpf->fd_tcp_rule++;\n \t\tif (pf->flags & I40E_FLAG_FD_ATR_ENABLED) {\n-\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 flow being applied\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"Forcing ATR off, sideband rules for TCP/IPv4 flow being applied\\n\");\n \t\t\tpf->flags &= ~I40E_FLAG_FD_ATR_ENABLED;\n \t\t}\n \t} else {\n@@ -291,7 +292,8 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,\n \t\t\t\t (pf->fd_tcp_rule - 1) : 0;\n \t\tif (pf->fd_tcp_rule == 0) {\n \t\t\tpf->flags |= I40E_FLAG_FD_ATR_ENABLED;\n-\t\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled due to no sideband TCP/IPv4 rules\\n\");\n+\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"ATR re-enabled due to no sideband TCP/IPv4 rules\\n\");\n \t\t}\n \t}\n \n@@ -501,7 +503,8 @@ static void i40e_fd_handle_status(struct i40e_ring *rx_ring,\n \t\t\tif ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&\n \t\t\t !(pf->auto_disable_flags &\n \t\t\t\t I40E_FLAG_FD_SB_ENABLED)) {\n-\t\t\t\tdev_warn(&pdev->dev, \"FD filter space full, new ntuple rules will not be added\\n\");\n+\t\t\t\tif (I40E_DEBUG_FD & pf->hw.debug_mask)\n+\t\t\t\t\tdev_warn(&pdev->dev, \"FD filter space full, new ntuple rules will not be added\\n\");\n \t\t\t\tpf->auto_disable_flags |=\n \t\t\t\t\t\t\tI40E_FLAG_FD_SB_ENABLED;\n \t\t\t}\n", "prefixes": [ "net-next", "S4", "09/15" ] }