Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/460940/?format=api
{ "id": 460940, "url": "http://patchwork.ozlabs.org/api/patches/460940/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428916512-25559-1-git-send-email-makita.toshiaki@lab.ntt.co.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1428916512-25559-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>", "list_archive_url": null, "date": "2015-04-13T09:15:10", "name": "[net,1/2] igb: Fix oops on changing number of rings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ad76a00d849e74f95132d4c5795fe6d1f08d4d02", "submitter": { "id": 22461, "url": "http://patchwork.ozlabs.org/api/people/22461/?format=api", "name": "Toshiaki Makita", "email": "makita.toshiaki@lab.ntt.co.jp" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428916512-25559-1-git-send-email-makita.toshiaki@lab.ntt.co.jp/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/460940/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/460940/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 5E30A140280\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 14 Apr 2015 06:56:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 469108C613;\n\tMon, 13 Apr 2015 20:56:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wQENK6vZUKSg; Mon, 13 Apr 2015 20:56:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 55F998C516;\n\tMon, 13 Apr 2015 20:56:48 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C7BF81C1FC8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Apr 2015 09:28:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C095F8B929\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Apr 2015 09:28:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jnWjVAc0qO06 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Apr 2015 09:28:26 +0000 (UTC)", "from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8EED48B8FA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Apr 2015 09:28:26 +0000 (UTC)", "from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153])\n\tby tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id t3D9FSuU012923; \n\tMon, 13 Apr 2015 18:15:28 +0900", "from vc1.ecl.ntt.co.jp (localhost [127.0.0.1])\n\tby vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 6178B5F611;\n\tMon, 13 Apr 2015 18:15:28 +0900 (JST)", "from imail3.m.ecl.ntt.co.jp (imail3.m.ecl.ntt.co.jp [129.60.5.248])\n\tby vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 463F95F590;\n\tMon, 13 Apr 2015 18:15:28 +0900 (JST)", "from ubuntu-vm-makita ([129.60.241.251])\n\tby imail3.m.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id\n\tt3D9FLXU026274; Mon, 13 Apr 2015 18:15:28 +0900", "by ubuntu-vm-makita (Postfix, from userid 1000)\n\tid 8D4D01E6429; Mon, 13 Apr 2015 18:15:18 +0900 (JST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Mon, 13 Apr 2015 18:15:10 +0900", "Message-Id": "<1428916512-25559-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>", "X-Mailer": "git-send-email 1.8.1.2", "X-TM-AS-MML": "disable", "X-Mailman-Approved-At": "Mon, 13 Apr 2015 20:56:46 +0000", "Cc": "intel-wired-lan@lists.osuosl.org,\n\tToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>", "Subject": "[Intel-wired-lan] [PATCH net 1/2] igb: Fix oops on changing number\n\tof rings", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When changing the number of rings by ethtool -L, q_vectors are reused,\nwhich causes oops because of uninitialized pointers.\n\n- When an rx is reused as a tx, q_vector->rx.ring is not set to NULL, which\n misleads igb_poll() to determine that it has an rx ring although it\n actually points to the tx ring.\n- When a tx is reused as an rx, q_vector->rx.ring->skb\n (q_vector->ring[0].skb) has a value that was used as tx_stats before.\n\nFix these problems by zeroing it out on reuseing it.\n\nFixes: 02ef6e1d0b00 (\"igb: Fix queue allocation method to accommodate changing during runtime\")\nSigned-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex f366b3b..010ddcb 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -1207,6 +1207,8 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,\n \tq_vector = adapter->q_vector[v_idx];\n \tif (!q_vector)\n \t\tq_vector = kzalloc(size, GFP_KERNEL);\n+\telse\n+\t\tmemset(q_vector, 0, size);\n \tif (!q_vector)\n \t\treturn -ENOMEM;\n \n", "prefixes": [ "net", "1/2" ] }