Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/459835/?format=api
{ "id": 459835, "url": "http://patchwork.ozlabs.org/api/patches/459835/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150409214405.27465.51380.stgit@gmw-smvitp108.amr.corp.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150409214405.27465.51380.stgit@gmw-smvitp108.amr.corp.intel.com>", "list_archive_url": null, "date": "2015-04-09T21:45:12", "name": "[net-next,v2] e1000e: fix call to do_div() to use u64 arg", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6be2f65c1e887014b0b7d5a5635453d59f9db2e9", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150409214405.27465.51380.stgit@gmw-smvitp108.amr.corp.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/459835/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/459835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 5616A1401F0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Apr 2015 07:45:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7D6C091C0A;\n\tThu, 9 Apr 2015 21:45:16 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rGDzgudDmB3t; Thu, 9 Apr 2015 21:45:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CF43891B32;\n\tThu, 9 Apr 2015 21:45:15 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 38B2C1C234E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 21:45:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 336D591B32\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 21:45:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mEUy-Ay3GzXH for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 21:45:13 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 559F591BFC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 21:45:13 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 09 Apr 2015 14:45:12 -0700", "from bjhicke1-mobl.amr.corp.intel.com (HELO\n\tgmw-smvitp108.amr.corp.intel.com) ([10.254.74.251])\n\tby fmsmga002.fm.intel.com with ESMTP; 09 Apr 2015 14:45:12 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,552,1422950400\"; d=\"scan'208\";a=\"706504062\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 09 Apr 2015 14:45:12 -0700", "Message-ID": "<20150409214405.27465.51380.stgit@gmw-smvitp108.amr.corp.intel.com>", "User-Agent": "StGit/0.17-dirty", "MIME-Version": "1.0", "Cc": "david.laight@aculab.com, Yanjiang Jin <yanjiang.jin@windriver.com>", "Subject": "[Intel-wired-lan] [net-next v2] e1000e: fix call to do_div() to use\n\tu64 arg", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "We were using s64 for lat_ns (latency nano-second value) since in\nour calculations a negative value could be a resultant. For negative\nvalues, we then assign lat_ns to be zero, so the value passed to\ndo_div() was never negative, but do_div() expects the argument type\nto be u64, so do a cast to resolve a compile warning seen on\nPowerPC.\n\nCC: Yanjiang Jin <yanjiang.jin@windriver.com>\nCC: Yanir Lubetkin <yanirx.lubetkin@intel.com>\nReported-by: Yanjiang Jin <yanjiang.jin@windriver.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\nv2: fixed the patch to not use a cast to resolve the PowerPC compile\n warning\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 9d81c03..7053863 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1015,7 +1015,7 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)\n \t\tu16 max_snoop, max_nosnoop;\n \t\tu16 max_ltr_enc;\t/* max LTR latency encoded */\n \t\ts64 lat_ns;\t/* latency (ns) */\n-\t\ts64 value;\n+\t\tu64 value;\n \t\tu32 rxa;\n \n \t\tif (!hw->adapter->max_frame_size) {\n@@ -1042,12 +1042,13 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)\n \t\t */\n \t\tlat_ns = ((s64)rxa * 1024 -\n \t\t\t (2 * (s64)hw->adapter->max_frame_size)) * 8 * 1000;\n-\t\tif (lat_ns < 0)\n-\t\t\tlat_ns = 0;\n-\t\telse\n-\t\t\tdo_div(lat_ns, speed);\n+\t\tif (lat_ns < 0) {\n+\t\t\tvalue = 0;\n+\t\t} else {\n+\t\t\tvalue = lat_ns;\n+\t\t\tdo_div(value, speed);\n+\t\t}\n \n-\t\tvalue = lat_ns;\n \t\twhile (value > PCI_LTR_VALUE_MASK) {\n \t\t\tscale++;\n \t\t\tvalue = DIV_ROUND_UP(value, (1 << 5));\n", "prefixes": [ "net-next", "v2" ] }