Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/459557/?format=api
{ "id": 459557, "url": "http://patchwork.ozlabs.org/api/patches/459557/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150409013554.3231.10427.stgit@ahduyck-vm-fedora22/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20150409013554.3231.10427.stgit@ahduyck-vm-fedora22>", "list_archive_url": null, "date": "2015-04-09T01:37:07", "name": "e1000e: Do not allow CRC stripping to be disabled on 82579 w/ jumbo frames", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e351aba99b05bf3817f3a98bcb22f3c97653c4fa", "submitter": { "id": 64958, "url": "http://patchwork.ozlabs.org/api/people/64958/?format=api", "name": "Alexander Duyck", "email": "alexander.h.duyck@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20150409013554.3231.10427.stgit@ahduyck-vm-fedora22/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/459557/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/459557/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id B6AD71402D8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 9 Apr 2015 11:37:14 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EACF7A2F78;\n\tThu, 9 Apr 2015 01:37:13 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tYvjYucGpCaM; Thu, 9 Apr 2015 01:37:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CE019A2F35;\n\tThu, 9 Apr 2015 01:37:12 +0000 (UTC)", "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4AC9F1BF9A7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 01:37:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2BB0C314D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 01:37:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4wV17oc0TZx5 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 01:37:11 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id EBC8925329\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Apr 2015 01:37:10 +0000 (UTC)", "from int-mx09.intmail.prod.int.phx2.redhat.com\n\t(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\tby mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t391b8Pd030648\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=FAIL); Wed, 8 Apr 2015 21:37:08 -0400", "from [192.168.122.149] ([10.3.112.3])\n\tby int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t391b7Na006830; Wed, 8 Apr 2015 21:37:07 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Alexander Duyck <alexander.h.duyck@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Wed, 08 Apr 2015 18:37:07 -0700", "Message-ID": "<20150409013554.3231.10427.stgit@ahduyck-vm-fedora22>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.22", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Do not allow CRC stripping to be\n\tdisabled on 82579 w/ jumbo frames", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The driver wasn't allowing jumbo frames to be enabled when CRC stripping\nwas disabled, however it was allowing CRC stripping to be disabled while\njumbo frames were enabled. This fixes that by making it so that the\nNETIF_F_RXFCS flag cannot be set when jumbo frames are enabled on 82579 and\nnewer parts.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex f77db9304060..5af46b8a9a16 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -6676,6 +6676,19 @@ static void e1000_eeprom_checks(struct e1000_adapter *adapter)\n \t}\n }\n \n+static netdev_features_t e1000_fix_features(struct net_device *netdev,\n+\t\t\t\t\t netdev_features_t features)\n+{\n+\tstruct e1000_adapter *adapter = netdev_priv(netdev);\n+\tstruct e1000_hw *hw = &adapter->hw;\n+\n+\t/* Jumbo frame workaround on 82579 and newer requires CRC be stripped */\n+\tif ((hw->mac.type >= e1000_pch2lan) && (netdev->mtu > ETH_DATA_LEN))\n+\t\tfeatures &= ~NETIF_F_RXFCS;\n+\n+\treturn features;\n+}\n+\n static int e1000_set_features(struct net_device *netdev,\n \t\t\t netdev_features_t features)\n {\n@@ -6732,6 +6745,7 @@ static const struct net_device_ops e1000e_netdev_ops = {\n \t.ndo_poll_controller\t= e1000_netpoll,\n #endif\n \t.ndo_set_features = e1000_set_features,\n+\t.ndo_fix_features = e1000_fix_features,\n };\n \n /**\n", "prefixes": [] }