Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/459059/?format=api
{ "id": 459059, "url": "http://patchwork.ozlabs.org/api/patches/459059/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428450342-48517-10-git-send-email-catherine.sullivan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1428450342-48517-10-git-send-email-catherine.sullivan@intel.com>", "list_archive_url": null, "date": "2015-04-07T23:45:39", "name": "[net-next,S3,10/13] i40e: handle possible memory allocation failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e63de7581fe8785a07deccdd4264b9198b5884c2", "submitter": { "id": 13931, "url": "http://patchwork.ozlabs.org/api/people/13931/?format=api", "name": "Catherine Sullivan", "email": "catherine.sullivan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428450342-48517-10-git-send-email-catherine.sullivan@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/459059/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/459059/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 7DE84140187\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Apr 2015 09:42:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CAFA933437;\n\tTue, 7 Apr 2015 23:42:35 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 74y4rm4T7+QQ; Tue, 7 Apr 2015 23:42:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 44ED73341F;\n\tTue, 7 Apr 2015 23:42:33 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id EFC851C265F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2015 23:42:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EB25F90D90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2015 23:42:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JCu5YDx4nUOJ for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2015 23:42:31 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 359E78C49B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2015 23:42:31 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP; 07 Apr 2015 16:42:31 -0700", "from catheri1-tigger.jf.intel.com ([134.134.176.92])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Apr 2015 16:42:30 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,540,1422950400\"; d=\"scan'208\";a=\"477975462\"", "From": "Catherine Sullivan <catherine.sullivan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Apr 2015 19:45:39 -0400", "Message-Id": "<1428450342-48517-10-git-send-email-catherine.sullivan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1428450342-48517-1-git-send-email-catherine.sullivan@intel.com>", "References": "<1428450342-48517-1-git-send-email-catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [net-next S3 10/13] i40e: handle possible memory\n\tallocation failure", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe init_interrupt_scheme function had a possible failure\npath to allocate memory that was found by smatch.\n\nThis adds the correct handling to the function to abort\nprobe if the memory allocation fails.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I2bf1d826a244209619da4c452d0d58b3eb5e26a3\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 63de3f4..b297294 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7301,7 +7301,7 @@ err_out:\n * i40e_init_interrupt_scheme - Determine proper interrupt scheme\n * @pf: board private structure to initialize\n **/\n-static void i40e_init_interrupt_scheme(struct i40e_pf *pf)\n+static int i40e_init_interrupt_scheme(struct i40e_pf *pf)\n {\n \tint vectors = 0;\n \tssize_t size;\n@@ -7343,11 +7343,17 @@ static void i40e_init_interrupt_scheme(struct i40e_pf *pf)\n \t/* set up vector assignment tracking */\n \tsize = sizeof(struct i40e_lump_tracking) + (sizeof(u16) * vectors);\n \tpf->irq_pile = kzalloc(size, GFP_KERNEL);\n+\tif (!pf->irq_pile) {\n+\t\tdev_err(&pf->pdev->dev, \"error allocating irq_pile memory\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n \tpf->irq_pile->num_entries = vectors;\n \tpf->irq_pile->search_hint = 0;\n \n-\t/* track first vector for misc interrupts */\n+\t/* track first vector for misc interrupts, ignore return */\n \t(void)i40e_get_lump(pf, pf->irq_pile, 1, I40E_PILE_VALID_BIT - 1);\n+\n+\treturn 0;\n }\n \n /**\n@@ -9827,7 +9833,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \n \t/* set up the main switch operations */\n \ti40e_determine_queue_usage(pf);\n-\ti40e_init_interrupt_scheme(pf);\n+\terr = i40e_init_interrupt_scheme(pf);\n+\tif (err)\n+\t\tgoto err_switch_setup;\n \n \t/* The number of VSIs reported by the FW is the minimum guaranteed\n \t * to us; HW supports far more and we share the remaining pool with\n", "prefixes": [ "net-next", "S3", "10/13" ] }