Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/458051/?format=api
{ "id": 458051, "url": "http://patchwork.ozlabs.org/api/patches/458051/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428092835-16834-21-git-send-email-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1428092835-16834-21-git-send-email-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2015-04-03T20:27:11", "name": "[net-next,21/25] fm10k: update xcast mode before synchronizing multicast addresses", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a9f0f71883cfe2cc6a6e531f42924614f06cf4cd", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428092835-16834-21-git-send-email-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/458051/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/458051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 61B861400B7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 4 Apr 2015 07:27:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B27FDA407F;\n\tFri, 3 Apr 2015 20:27:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l5vie4oSPsmX; Fri, 3 Apr 2015 20:27:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6A2AEA4040;\n\tFri, 3 Apr 2015 20:27:27 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A6E251C2A8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A2F3892175\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rl2-B0c1o3rj for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2953892173\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 03 Apr 2015 13:27:22 -0700", "from lwang4-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-mobl.amr.corp.intel.com) ([10.254.109.203])\n\tby FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2015 13:27:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,519,1422950400\"; d=\"scan'208\";a=\"476517951\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 3 Apr 2015 13:27:11 -0700", "Message-Id": "<1428092835-16834-21-git-send-email-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1428092835-16834-1-git-send-email-jeffrey.t.kirsher@intel.com>", "References": "<1428092835-16834-1-git-send-email-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [net-next 21/25] fm10k: update xcast mode before\n\tsynchronizing multicast addresses", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When the PF receives a request to update a multicast address for the VF,\nit checks the enabled multicast mode first. Fix a bug where the VF tried\nto set a multicast address before requesting the required xcast mode.\nThis ensures the multicast addresses are honored as long as the xcast\nmode was allowed.\n\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nAcked-by: Matthew Vick <matthew.vick@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex c9f87bb..7f5c36a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -966,14 +966,7 @@ static void fm10k_set_rx_mode(struct net_device *dev)\n \n \tfm10k_mbx_lock(interface);\n \n-\t/* synchronize all of the addresses */\n-\tif (xcast_mode != FM10K_XCAST_MODE_PROMISC) {\n-\t\t__dev_uc_sync(dev, fm10k_uc_sync, fm10k_uc_unsync);\n-\t\tif (xcast_mode != FM10K_XCAST_MODE_ALLMULTI)\n-\t\t\t__dev_mc_sync(dev, fm10k_mc_sync, fm10k_mc_unsync);\n-\t}\n-\n-\t/* if we aren't changing modes there is nothing to do */\n+\t/* update xcast mode first, but only if it changed */\n \tif (interface->xcast_mode != xcast_mode) {\n \t\t/* update VLAN table */\n \t\tif (xcast_mode == FM10K_XCAST_MODE_PROMISC)\n@@ -988,6 +981,13 @@ static void fm10k_set_rx_mode(struct net_device *dev)\n \t\tinterface->xcast_mode = xcast_mode;\n \t}\n \n+\t/* synchronize all of the addresses */\n+\tif (xcast_mode != FM10K_XCAST_MODE_PROMISC) {\n+\t\t__dev_uc_sync(dev, fm10k_uc_sync, fm10k_uc_unsync);\n+\t\tif (xcast_mode != FM10K_XCAST_MODE_ALLMULTI)\n+\t\t\t__dev_mc_sync(dev, fm10k_mc_sync, fm10k_mc_unsync);\n+\t}\n+\n \tfm10k_mbx_unlock(interface);\n }\n \n@@ -1047,6 +1047,9 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \t\t\t\t\t vid, true, 0);\n \t}\n \n+\t/* update xcast mode before syncronizing addresses */\n+\thw->mac.ops.update_xcast_mode(hw, glort, xcast_mode);\n+\n \t/* synchronize all of the addresses */\n \tif (xcast_mode != FM10K_XCAST_MODE_PROMISC) {\n \t\t__dev_uc_sync(netdev, fm10k_uc_sync, fm10k_uc_unsync);\n@@ -1054,9 +1057,6 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \t\t\t__dev_mc_sync(netdev, fm10k_mc_sync, fm10k_mc_unsync);\n \t}\n \n-\t/* update xcast mode */\n-\thw->mac.ops.update_xcast_mode(hw, glort, xcast_mode);\n-\n \tfm10k_mbx_unlock(interface);\n \n \t/* record updated xcast mode state */\n", "prefixes": [ "net-next", "21/25" ] }