Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/458046/?format=api
{ "id": 458046, "url": "http://patchwork.ozlabs.org/api/patches/458046/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428092835-16834-19-git-send-email-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1428092835-16834-19-git-send-email-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2015-04-03T20:27:09", "name": "[net-next,19/25] fm10k: start service timer on probe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1858bb5bb7fda0c747ad3de8189298d91ed98136", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1428092835-16834-19-git-send-email-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/458046/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/458046/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 28BE114018C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 4 Apr 2015 07:27:30 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7D772A3FCA;\n\tFri, 3 Apr 2015 20:27:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B7XYCH4Pt-g2; Fri, 3 Apr 2015 20:27:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7CB10A40BC;\n\tFri, 3 Apr 2015 20:27:27 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DAEF91C2A8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D352D92170\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id W8207x-m+DhM for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:22 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8D1F192166\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2015 20:27:22 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 03 Apr 2015 13:27:22 -0700", "from lwang4-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-mobl.amr.corp.intel.com) ([10.254.109.203])\n\tby FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2015 13:27:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,519,1422950400\"; d=\"scan'208\";a=\"476517943\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 3 Apr 2015 13:27:09 -0700", "Message-Id": "<1428092835-16834-19-git-send-email-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1428092835-16834-1-git-send-email-jeffrey.t.kirsher@intel.com>", "References": "<1428092835-16834-1-git-send-email-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [net-next 19/25] fm10k: start service timer on\n\tprobe", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Since the service task handles varying work that doesn't all require the\ninterface to be up, launch the service timer immediately. This ensures\nthat we continually check the mailbox, as well as handle other tasks\nwhile the device is down.\n\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nAcked-by: Matthew Vick <matthew.vick@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 25458ca..cc527dd 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1489,7 +1489,7 @@ void fm10k_up(struct fm10k_intfc *interface)\n \t/* enable transmits */\n \tnetif_tx_start_all_queues(interface->netdev);\n \n-\t/* kick off the service timer */\n+\t/* kick off the service timer now */\n \thw->mac.get_host_state = 1;\n \tmod_timer(&interface->service_timer, jiffies);\n }\n@@ -1529,8 +1529,6 @@ void fm10k_down(struct fm10k_intfc *interface)\n \t/* disable polling routines */\n \tfm10k_napi_disable_all(interface);\n \n-\tdel_timer_sync(&interface->service_timer);\n-\n \t/* capture stats one last time before stopping interface */\n \tfm10k_update_stats(interface);\n \n@@ -1656,6 +1654,9 @@ static int fm10k_sw_init(struct fm10k_intfc *interface,\n \t\t (unsigned long)interface);\n \tINIT_WORK(&interface->service_task, fm10k_service_task);\n \n+\t/* kick off service timer now, even when interface is down */\n+\tmod_timer(&interface->service_timer, (HZ * 2) + jiffies);\n+\n \t/* Intitialize timestamp data */\n \tfm10k_ts_init(interface);\n \n@@ -1872,6 +1873,8 @@ static void fm10k_remove(struct pci_dev *pdev)\n \tstruct fm10k_intfc *interface = pci_get_drvdata(pdev);\n \tstruct net_device *netdev = interface->netdev;\n \n+\tdel_timer_sync(&interface->service_timer);\n+\n \tset_bit(__FM10K_SERVICE_DISABLE, &interface->state);\n \tcancel_work_sync(&interface->service_task);\n \n", "prefixes": [ "net-next", "19/25" ] }