Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/453149/?format=api
{ "id": 453149, "url": "http://patchwork.ozlabs.org/api/patches/453149/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/52b512822f3dde3b5fcb7120a8755bf0fbd2b8ca.1427037564.git.yann.morin.1998@free.fr/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<52b512822f3dde3b5fcb7120a8755bf0fbd2b8ca.1427037564.git.yann.morin.1998@free.fr>", "list_archive_url": null, "date": "2015-03-22T15:21:05", "name": "[6/7,v3] support/download: always fail when there's no hash", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "7f1f7d5ea9fe6976c5ab1bd7d67194f260159867", "submitter": { "id": 13903, "url": "http://patchwork.ozlabs.org/api/people/13903/?format=api", "name": "Yann E. MORIN", "email": "yann.morin.1998@free.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/52b512822f3dde3b5fcb7120a8755bf0fbd2b8ca.1427037564.git.yann.morin.1998@free.fr/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/453149/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/453149/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id A5E5A14011D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 23 Mar 2015 02:21:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D0DF332C0F;\n\tSun, 22 Mar 2015 15:21:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qcR8wqyZqZPe; Sun, 22 Mar 2015 15:21:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9201432C8D;\n\tSun, 22 Mar 2015 15:21:26 +0000 (UTC)", "from whitealder.osuosl.org (whitealder.osuosl.org\n\t[140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9ED1B1C2097\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9948A9161B\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:18 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ECZvqHO+1mxQ for <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:17 +0000 (UTC)", "from mail-we0-f172.google.com (mail-we0-f172.google.com\n\t[74.125.82.172])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 0F71491606\n\tfor <buildroot@buildroot.org>; Sun, 22 Mar 2015 15:21:17 +0000 (UTC)", "by webee49 with SMTP id ee49so9405444web.2\n\tfor <buildroot@buildroot.org>; Sun, 22 Mar 2015 08:21:15 -0700 (PDT)", "from gourin.bzh.lan (ns304657.ip-46-105-103.eu. [46.105.103.66])\n\tby mx.google.com with ESMTPSA id\n\t14sm15244710wjv.29.2015.03.22.08.21.14\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 22 Mar 2015 08:21:14 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org; dkim=fail\n\treason=\"verification failed; unprotected key\"\n\theader.d=gmail.com header.i=@gmail.com header.b=Ul9iuuqf;\n\tdkim-adsp=none (unprotected policy); dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=rRX6EwUGADhvvfWqyaaUWp/DoFrcMBft5rmebv3qIC0=;\n\tb=Ul9iuuqfFymicNk43/zlQnexoWEhZkWqyEjz/2UPF2GX78w0UqBVRjKxQI6SV4Why+\n\tRepu/1Av/26Cm1Pah7CtfkD++vPIujzCBUpR1e3j0RAgpC+H/kePkEwxTOmaF9HgqS0N\n\t1lS41zS2gxsD64CaviKrMBgDxL0Dq4Fvp6opFc3DXwvgO3KNQcaYALaXVtmGsbBq8wZH\n\tn96xtPL+ToHiPSB0anrUHicMNigJcJVjg6QMJXBCL5OSDjEKdpIJdEIqFshnHBny0a2e\n\totTye3MkWuFC/4nRQsawscXfti+dPJwqyIfobSJmnCig2+B6/WWaHIPcCVDTi5kXjR7m\n\tMIiw==", "X-Received": "by 10.194.237.34 with SMTP id\n\tuz2mr174039102wjc.157.1427037675581; \n\tSun, 22 Mar 2015 08:21:15 -0700 (PDT)", "From": "\"Yann E. MORIN\" <yann.morin.1998@free.fr>", "To": "buildroot@buildroot.org", "Date": "Sun, 22 Mar 2015 16:21:05 +0100", "Message-Id": "<52b512822f3dde3b5fcb7120a8755bf0fbd2b8ca.1427037564.git.yann.morin.1998@free.fr>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<cover.1427037564.git.yann.morin.1998@free.fr>", "References": "<cover.1427037564.git.yann.morin.1998@free.fr>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\t\"Yann E. MORIN\" <yann.morin.1998@free.fr>", "Subject": "[Buildroot] [PATCH 6/7 v3] support/download: always fail when\n\tthere's no hash", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "At the time we introduced hashes, we did not want to be too harsh in the\nbeginning, and give people some time to adapt and accept the hashes. So\nwe so far only whined^Wwarned about a missing hash (when the .hash file\nexists).\n\nSome time has passed now, and people are still missing updating hashes\nwhen bumping packages.\n\nLet's make that warning a little bit more annoying...\n\nSigned-off-by: \"Yann E. MORIN\" <yann.morin.1998@free.fr>\nCc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>\nCc: Arnout Vandecappelle <arnout@mind.be>\nReviewed-by: Samuel Martin <s.martin49@gmail.com>\n\n---\nChanges v2 -> v3:\n - further improve the manual (Arnout)\n---\n docs/manual/adding-packages-directory.txt | 8 ++++----\n support/download/check-hash | 8 ++------\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt\nindex 0f8bb64..0051fea 100644\n--- a/docs/manual/adding-packages-directory.txt\n+++ b/docs/manual/adding-packages-directory.txt\n@@ -478,10 +478,10 @@ not match, Buildroot considers this an error, deletes the downloaded file,\n and aborts.\n \n If the +.hash+ file is present, but it does not contain a hash for a\n-downloaded file, no check is done for that file. If you set the\n-environment variable +BR2_ENFORCE_CHECK_HASH+ to a non-empty value, and\n-there is no hash for a downloaded file, Buildroot considers this an\n-error, deletes the downloaded file, and aborts.\n+downloaded file, Buildroot considers this an error and aborts. However,\n+the downloaded file is left in the download directory since this\n+typically indicates that the +.hash+ file is wrong but the downloaded\n+file is probably OK.\n \n Sources that are downloaded from a version control system (git, subversion,\n etc...) can not have a hash, because the version control system and tar\ndiff --git a/support/download/check-hash b/support/download/check-hash\nindex 0234ab0..d200868 100755\n--- a/support/download/check-hash\n+++ b/support/download/check-hash\n@@ -92,10 +92,6 @@ while read t h f; do\n done <\"${h_file}\"\n \n if [ ${nb_checks} -eq 0 ]; then\n- if [ -n \"${BR2_ENFORCE_CHECK_HASH}\" ]; then\n- printf \"ERROR: No hash found for %s\\n\" \"${base}\" >&2\n- exit 3\n- else\n- printf \"WARNING: No hash found for %s\\n\" \"${base}\" >&2\n- fi\n+ printf \"ERROR: No hash found for %s\\n\" \"${base}\" >&2\n+ exit 3\n fi\n", "prefixes": [ "6/7", "v3" ] }