Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/453145/?format=api
{ "id": 453145, "url": "http://patchwork.ozlabs.org/api/patches/453145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/cb1bbce764c2269fda3da97e99161ad376fc6a89.1427037564.git.yann.morin.1998@free.fr/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<cb1bbce764c2269fda3da97e99161ad376fc6a89.1427037564.git.yann.morin.1998@free.fr>", "list_archive_url": null, "date": "2015-03-22T15:21:01", "name": "[2/7,v3] package infra: do not check hashes when downloading from a repository", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "331ac14ac72a8b9febfec26353eda2d86a3ed064", "submitter": { "id": 13903, "url": "http://patchwork.ozlabs.org/api/people/13903/?format=api", "name": "Yann E. MORIN", "email": "yann.morin.1998@free.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/cb1bbce764c2269fda3da97e99161ad376fc6a89.1427037564.git.yann.morin.1998@free.fr/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/453145/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/453145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 65DCA14011D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 23 Mar 2015 02:21:26 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B573432C86;\n\tSun, 22 Mar 2015 15:21:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dDYSiAA4U+Sq; Sun, 22 Mar 2015 15:21:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D61FC3221C;\n\tSun, 22 Mar 2015 15:21:18 +0000 (UTC)", "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE88E1C2097\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CC08E94D63\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Tu7fsCzfV9VL for <buildroot@lists.busybox.net>;\n\tSun, 22 Mar 2015 15:21:12 +0000 (UTC)", "from mail-wi0-f171.google.com (mail-wi0-f171.google.com\n\t[209.85.212.171])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C468294CE4\n\tfor <buildroot@buildroot.org>; Sun, 22 Mar 2015 15:21:11 +0000 (UTC)", "by wibgn9 with SMTP id gn9so37115087wib.1\n\tfor <buildroot@buildroot.org>; Sun, 22 Mar 2015 08:21:10 -0700 (PDT)", "from gourin.bzh.lan (ns304657.ip-46-105-103.eu. [46.105.103.66])\n\tby mx.google.com with ESMTPSA id\n\t14sm15244710wjv.29.2015.03.22.08.21.09\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 22 Mar 2015 08:21:09 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org; dkim=fail\n\treason=\"verification failed; unprotected key\"\n\theader.d=gmail.com header.i=@gmail.com header.b=RefwV3Hp;\n\tdkim-adsp=none (unprotected policy); dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=lULIOKpAFeP77ftCMjyI9Rc2hXmJMsMsp/8KPtPL+W8=;\n\tb=RefwV3Hp6LYEgZz12/fx59nonNpRqxhdxrO6eaIMPkio1lDK7aor3J0e23H04+F/o6\n\tcuuoxdCM+vTqGv95G8959qFGAfYKoQ6Yk1U2U9QgWZfrv0N0Fn3mcYVy6c0LBXHCboS6\n\txr6fJkMB7/LDdGtYEusTaEFGMXa9xGtSgGhb3PJDshc0XwbGZRe/TaRlbzcQHg/07m1y\n\t6tp/WSlUjSX+lQawLbcLOSFmXA14Qo69Yp1W3zPLo4EQRc534lm00ChXE0fz0B7txda6\n\t86JmEeeygHx0ffzn4WtO+5dvKktKlQAxqrGPSoOD5qOdQ1QVc9sdwWvWsgbM9k1oesFs\n\t4rhw==", "X-Received": "by 10.194.178.164 with SMTP id cz4mr9488162wjc.140.1427037670418;\n\tSun, 22 Mar 2015 08:21:10 -0700 (PDT)", "From": "\"Yann E. MORIN\" <yann.morin.1998@free.fr>", "To": "buildroot@buildroot.org", "Date": "Sun, 22 Mar 2015 16:21:01 +0100", "Message-Id": "<cb1bbce764c2269fda3da97e99161ad376fc6a89.1427037564.git.yann.morin.1998@free.fr>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<cover.1427037564.git.yann.morin.1998@free.fr>", "References": "<cover.1427037564.git.yann.morin.1998@free.fr>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\t\"Yann E. MORIN\" <yann.morin.1998@free.fr>", "Subject": "[Buildroot] [PATCH 2/7 v3] package infra: do not check hashes when\n\tdownloading from a repository", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "When downloading from a repository, we have no way to ensure the\nreproducibility of the generated archives, so we can't check the hashes.\n\nDo not specifiy a hash file in those cases.\n\nSigned-off-by: \"Yann E. MORIN\" <yann.morin.1998@free.fr>\nCc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>\nReviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>\n\n---\nChanges v2 -> v3:\n - add blurb in the manual (Arnout)\n---\n docs/manual/adding-packages-directory.txt | 6 ++++++\n package/pkg-download.mk | 5 -----\n 2 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt\nindex 1ce9a3b..132c702 100644\n--- a/docs/manual/adding-packages-directory.txt\n+++ b/docs/manual/adding-packages-directory.txt\n@@ -474,4 +474,10 @@ environment variable +BR2_ENFORCE_CHECK_HASH+ to a non-empty value, and\n there is no hash for a downloaded file, Buildroot considers this an\n error, deletes the downloaded file, and aborts.\n \n+Sources that are downloaded from a version control system (git, subversion,\n+etc...) can not have a hash, because the version control system and tar\n+may not create exactly the same file (dates, files ordering...), so the\n+hash could be wrong even for a valid download. Therefore, the hash check\n+is entirely skipped for such sources.\n+\n If the +.hash+ file is missing, then no check is done at all.\ndiff --git a/package/pkg-download.mk b/package/pkg-download.mk\nindex 5e74519..e274712 100644\n--- a/package/pkg-download.mk\n+++ b/package/pkg-download.mk\n@@ -87,7 +87,6 @@ github = https://github.com/$(1)/$(2)/archive/$(3)\n define DOWNLOAD_GIT\n \t$(EXTRA_ENV) $(DL_WRAPPER) -b git \\\n \t\t-o $(DL_DIR)/$($(PKG)_SOURCE) \\\n-\t\t-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \\\n \t\t$(QUIET) \\\n \t\t-- \\\n \t\t$($(PKG)_SITE) \\\n@@ -109,7 +108,6 @@ endef\n define DOWNLOAD_BZR\n \t$(EXTRA_ENV) $(DL_WRAPPER) -b bzr \\\n \t\t-o $(DL_DIR)/$($(PKG)_SOURCE) \\\n-\t\t-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \\\n \t\t$(QUIET) \\\n \t\t-- \\\n \t\t$($(PKG)_SITE) \\\n@@ -128,7 +126,6 @@ endef\n define DOWNLOAD_CVS\n \t$(EXTRA_ENV) $(DL_WRAPPER) -b cvs \\\n \t\t-o $(DL_DIR)/$($(PKG)_SOURCE) \\\n-\t\t-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \\\n \t\t$(QUIET) \\\n \t\t-- \\\n \t\t$(call stripurischeme,$(call qstrip,$($(PKG)_SITE))) \\\n@@ -149,7 +146,6 @@ endef\n define DOWNLOAD_SVN\n \t$(EXTRA_ENV) $(DL_WRAPPER) -b svn \\\n \t\t-o $(DL_DIR)/$($(PKG)_SOURCE) \\\n-\t\t-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \\\n \t\t$(QUIET) \\\n \t\t-- \\\n \t\t$($(PKG)_SITE) \\\n@@ -189,7 +185,6 @@ endef\n define DOWNLOAD_HG\n \t$(EXTRA_ENV) $(DL_WRAPPER) -b hg \\\n \t\t-o $(DL_DIR)/$($(PKG)_SOURCE) \\\n-\t\t-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \\\n \t\t$(QUIET) \\\n \t\t-- \\\n \t\t$($(PKG)_SITE) \\\n", "prefixes": [ "2/7", "v3" ] }