Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/37547/?format=api
{ "id": 37547, "url": "http://patchwork.ozlabs.org/api/patches/37547/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1257328160-24955-1-git-send-email-w.sang@pengutronix.de/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1257328160-24955-1-git-send-email-w.sang@pengutronix.de>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1257328160-24955-1-git-send-email-w.sang@pengutronix.de/", "date": "2009-11-04T09:49:20", "name": "spi/mpc52xx: replace printk with dev_err", "commit_ref": "5cc17d7e01abd77eda1267a75748cfc84c92a523", "pull_url": null, "state": "accepted", "archived": true, "hash": "f00700c608f795ab3dc659115a61f2aee1a44aec", "submitter": { "id": 263, "url": "http://patchwork.ozlabs.org/api/people/263/?format=api", "name": "Wolfram Sang", "email": "w.sang@pengutronix.de" }, "delegate": { "id": 8, "url": "http://patchwork.ozlabs.org/api/users/8/?format=api", "username": "glikely", "first_name": "Grant", "last_name": "Likely", "email": "grant.likely@secretlab.ca" }, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1257328160-24955-1-git-send-email-w.sang@pengutronix.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/37547/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/37547/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from bilbo.ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 343D110090E\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 4 Nov 2009 20:49:40 +1100 (EST)", "by ozlabs.org (Postfix)\n\tid F02F1B7BC1; Wed, 4 Nov 2009 20:49:33 +1100 (EST)", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[92.198.50.35]) by ozlabs.org (Postfix) with ESMTP id 91F41B7BBF\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 4 Nov 2009 20:49:33 +1100 (EST)", "from [2001:6f8:1178:2:221:70ff:fe71:1890] (helo=pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtp (Exim 4.63)\n\t(envelope-from <w.sang@pengutronix.de>)\n\tid 1N5cUa-0007J6-50; Wed, 04 Nov 2009 10:49:28 +0100" ], "From": "Wolfram Sang <w.sang@pengutronix.de>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH] spi/mpc52xx: replace printk with dev_err", "Date": "Wed, 4 Nov 2009 10:49:20 +0100", "Message-Id": "<1257328160-24955-1-git-send-email-w.sang@pengutronix.de>", "X-Mailer": "git-send-email 1.6.3.3", "In-Reply-To": "<fa686aa40910311803m43504167s1ad802aecd2b4344@mail.gmail.com>", "References": "<fa686aa40910311803m43504167s1ad802aecd2b4344@mail.gmail.com>", "X-SA-Exim-Connect-IP": "2001:6f8:1178:2:221:70ff:fe71:1890", "X-SA-Exim-Mail-From": "w.sang@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false", "X-PTX-Original-Recipient": "linuxppc-dev@ozlabs.org", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org" }, "content": "To easily identify which device has problems.\n\nSigned-off-by: Wolfram Sang <w.sang@pengutronix.de>\nCc: Grant Likely <grant.likely@secretlab.ca>\n---\n drivers/spi/mpc52xx_psc_spi.c | 5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi/mpc52xx_psc_spi.c\nindex e268437..6fb6b3b 100644\n--- a/drivers/spi/mpc52xx_psc_spi.c\n+++ b/drivers/spi/mpc52xx_psc_spi.c\n@@ -471,7 +471,7 @@ static int __init mpc52xx_psc_spi_of_probe(struct of_device *op,\n \n \tregaddr_p = of_get_address(op->node, 0, &size64, NULL);\n \tif (!regaddr_p) {\n-\t\tprintk(KERN_ERR \"Invalid PSC address\\n\");\n+\t\tdev_err(&op->dev, \"Invalid PSC address\\n\");\n \t\treturn -EINVAL;\n \t}\n \tregaddr64 = of_translate_address(op->node, regaddr_p);\n@@ -482,8 +482,7 @@ static int __init mpc52xx_psc_spi_of_probe(struct of_device *op,\n \n \t\tpsc_nump = of_get_property(op->node, \"cell-index\", NULL);\n \t\tif (!psc_nump || *psc_nump > 5) {\n-\t\t\tprintk(KERN_ERR \"mpc52xx_psc_spi: Device node %s has invalid \"\n-\t\t\t\t\t\"cell-index property\\n\", op->node->full_name);\n+\t\t\tdev_err(&op->dev, \"Invalid cell-index property\\n\");\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tid = *psc_nump + 1;\n", "prefixes": [] }