Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/350336/?format=api
{ "id": 350336, "url": "http://patchwork.ozlabs.org/api/patches/350336/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1400518800-6111-4-git-send-email-ezequiel.garcia@free-electrons.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1400518800-6111-4-git-send-email-ezequiel.garcia@free-electrons.com>", "list_archive_url": null, "date": "2014-05-19T16:59:54", "name": "[3/9] net: mvneta: Clean mvneta_tx() sk_buff handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ca021b5573b951b7d98a077af904dbc8d9747097", "submitter": { "id": 20433, "url": "http://patchwork.ozlabs.org/api/people/20433/?format=api", "name": "Ezequiel Garcia", "email": "ezequiel.garcia@free-electrons.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1400518800-6111-4-git-send-email-ezequiel.garcia@free-electrons.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/350336/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/350336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 53895140082\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 20 May 2014 03:01:18 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932753AbaESRBG (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 19 May 2014 13:01:06 -0400", "from top.free-electrons.com ([176.31.233.9]:53599 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S932691AbaESRBC (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 19 May 2014 13:01:02 -0400", "by mail.free-electrons.com (Postfix, from userid 106)\n\tid AF1738BD; Mon, 19 May 2014 19:01:05 +0200 (CEST)", "from localhost.localdomain (unknown [190.2.108.30])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 5BACC7A9;\n\tMon, 19 May 2014 19:01:02 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.3.2 (2011-06-06) on\n\tmail.free-electrons.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.3.2", "From": "Ezequiel Garcia <ezequiel.garcia@free-electrons.com>", "To": "<netdev@vger.kernel.org>, David Miller <davem@davemloft.net>,\n\tEric Dumazet <eric.dumazet@gmail.com>", "Cc": "Willy Tarreau <w@1wt.eu>,\n\tThomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tGregory Clement <gregory.clement@free-electrons.com>,\n\tSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,\n\tTawfik Bayouk <tawfik@marvell.com>, Lior Amsalem <alior@marvell.com>,\n\tEzequiel Garcia <ezequiel.garcia@free-electrons.com>", "Subject": "[PATCH 3/9] net: mvneta: Clean mvneta_tx() sk_buff handling", "Date": "Mon, 19 May 2014 13:59:54 -0300", "Message-Id": "<1400518800-6111-4-git-send-email-ezequiel.garcia@free-electrons.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1400518800-6111-1-git-send-email-ezequiel.garcia@free-electrons.com>", "References": "<1400518800-6111-1-git-send-email-ezequiel.garcia@free-electrons.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Rework mvneta_tx() so that the code that performs the final handling\nbefore a sk_buff is transmitted is done only if the numbers of fragments\nprocessed if positive.\n\nThis is preparation work to add the support for software TSO.\n\nSigned-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>\n---\n drivers/net/ethernet/marvell/mvneta.c | 15 +++++++--------\n 1 file changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c\nindex ed7f924..8509029 100644\n--- a/drivers/net/ethernet/marvell/mvneta.c\n+++ b/drivers/net/ethernet/marvell/mvneta.c\n@@ -1584,7 +1584,6 @@ static int mvneta_tx(struct sk_buff *skb, struct net_device *dev)\n \tu16 txq_id = skb_get_queue_mapping(skb);\n \tstruct mvneta_tx_queue *txq = &pp->txqs[txq_id];\n \tstruct mvneta_tx_desc *tx_desc;\n-\tstruct netdev_queue *nq;\n \tint frags = 0;\n \tu32 tx_cmd;\n \n@@ -1592,7 +1591,6 @@ static int mvneta_tx(struct sk_buff *skb, struct net_device *dev)\n \t\tgoto out;\n \n \tfrags = skb_shinfo(skb)->nr_frags + 1;\n-\tnq = netdev_get_tx_queue(dev, txq_id);\n \n \t/* Get a descriptor for the first part of the packet */\n \ttx_desc = mvneta_txq_next_desc_get(txq);\n@@ -1635,15 +1633,16 @@ static int mvneta_tx(struct sk_buff *skb, struct net_device *dev)\n \t\t}\n \t}\n \n-\ttxq->count += frags;\n-\tmvneta_txq_pend_desc_add(pp, txq, frags);\n-\n-\tif (txq->size - txq->count < MAX_SKB_FRAGS + 1)\n-\t\tnetif_tx_stop_queue(nq);\n-\n out:\n \tif (frags > 0) {\n \t\tstruct mvneta_pcpu_stats *stats = this_cpu_ptr(pp->stats);\n+\t\tstruct netdev_queue *nq = netdev_get_tx_queue(dev, txq_id);\n+\n+\t\ttxq->count += frags;\n+\t\tmvneta_txq_pend_desc_add(pp, txq, frags);\n+\n+\t\tif (txq->size - txq->count < MAX_SKB_FRAGS + 1)\n+\t\t\tnetif_tx_stop_queue(nq);\n \n \t\tu64_stats_update_begin(&stats->syncp);\n \t\tstats->tx_packets++;\n", "prefixes": [ "3/9" ] }