Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/320344/?format=api
{ "id": 320344, "url": "http://patchwork.ozlabs.org/api/patches/320344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/1392371709-26662-5-git-send-email-fabio.porcedda@gmail.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1392371709-26662-5-git-send-email-fabio.porcedda@gmail.com>", "list_archive_url": null, "date": "2014-02-14T09:55:06", "name": "[v13,4/7] Makefile: add support for top-level parallel make", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "18db3b0f78c5616415b1808d65878b4adb0d7625", "submitter": { "id": 13215, "url": "http://patchwork.ozlabs.org/api/people/13215/?format=api", "name": "Fabio Porcedda", "email": "fabio.porcedda@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/1392371709-26662-5-git-send-email-fabio.porcedda@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/320344/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/320344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from silver.osuosl.org (silver.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 866DB2C0098\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Feb 2014 20:55:35 +1100 (EST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CC0F3251E0;\n\tFri, 14 Feb 2014 09:55:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RHbS3fjs+XwI; Fri, 14 Feb 2014 09:55:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5E73E330FB;\n\tFri, 14 Feb 2014 09:55:31 +0000 (UTC)", "from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3906D1C2358\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 14 Feb 2014 09:55:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 32BED93EFD\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 14 Feb 2014 09:55:30 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JK8KV7WTDzRc for <buildroot@lists.busybox.net>;\n\tFri, 14 Feb 2014 09:55:29 +0000 (UTC)", "from mail-pd0-f172.google.com (mail-pd0-f172.google.com\n\t[209.85.192.172])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 9FC6793EFB\n\tfor <buildroot@uclibc.org>; Fri, 14 Feb 2014 09:55:29 +0000 (UTC)", "by mail-pd0-f172.google.com with SMTP id p10so11736393pdj.17\n\tfor <buildroot@uclibc.org>; Fri, 14 Feb 2014 01:55:29 -0800 (PST)", "from ld2077.tmt.telital.com ([213.205.6.118])\n\tby mx.google.com with ESMTPSA id\n\tos1sm36815176pac.20.2014.02.14.01.55.24 for <multiple recipients>\n\t(version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tFri, 14 Feb 2014 01:55:27 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ZbPrOdA3nhh/DG3f+kgXg6tGNz2DEdtoMX9FWcDuISQ=;\n\tb=UtmpliNOjA8MiY0pUggE7ZDjlgSNZjcP0uFl5GANSJkE840Mm8MpHn7OcHL2WOYqaA\n\tOwsqEGh80qFksbv3VrNcwNSqDZLMo8CdNJGj4QvZFUSCIm4N4BlFlw8t71oZfk5k7Mvb\n\tBXdYkYPO+mrflxFcnMe5nYddCi0cWdVVCmAKioAwC+62czzW1zcZc1zv4ZMeGuKmTkQw\n\tG+020hR48Cs3CG2bNYcD+yvdX+W2nxYfQ5UGC66lxl/jatUb0iyu8y2PlHP8zxS7f50e\n\tMFGoY6s2eGEQ36dHvwtqrNHQCmU8j/mfzIqEZTeW+6uSzjNcIa7ZBa8YX60fJYqslHVL\n\tjLmA==", "X-Received": "by 10.68.211.1 with SMTP id my1mr8003260pbc.55.1392371727800;\n\tFri, 14 Feb 2014 01:55:27 -0800 (PST)", "From": "Fabio Porcedda <fabio.porcedda@gmail.com>", "To": "buildroot@uclibc.org", "Date": "Fri, 14 Feb 2014 10:55:06 +0100", "Message-Id": "<1392371709-26662-5-git-send-email-fabio.porcedda@gmail.com>", "X-Mailer": "git-send-email 1.8.5.2", "In-Reply-To": "<1392371709-26662-1-git-send-email-fabio.porcedda@gmail.com>", "References": "<1392371709-26662-1-git-send-email-fabio.porcedda@gmail.com>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tDallas Clement <dallas.a.clement@gmail.com>", "Subject": "[Buildroot] [PATCH v13 4/7] Makefile: add support for top-level\n\tparallel make", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.14", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "buildroot-bounces@busybox.net" }, "content": "To be able to use top-level parallel make we must not depend in a rule\non the order of evaluation of the prerequisites, so instead of relyng on\nthe left to right ordering of evaluation of the prerequisites add an\nexplicit rule to describe the dependencies.\n\nAdd explicit rules to describe the following dependency chain:\n$(TARGETS) -> target-finalize -> rootfs-* -> target-post-image\n\nSigned-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>\nAcked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>\n---\n Makefile | 21 ++++++++++++---------\n fs/common.mk | 4 ++--\n 2 files changed, 14 insertions(+), 11 deletions(-)", "diff": "diff --git a/Makefile b/Makefile\nindex 8e65bc7..c89107a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -377,8 +377,6 @@ include system/system.mk\n \n include $(BR2_EXTERNAL)/external.mk\n \n-TARGETS+=target-finalize\n-\n ifeq ($(BR2_ENABLE_LOCALE_PURGE),y)\n TARGETS+=target-purgelocales\n endif\n@@ -395,8 +393,6 @@ endif\n \n include fs/common.mk\n \n-TARGETS+=target-post-image\n-\n TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS) $(BASE_TARGETS))\n TARGETS_DIRCLEAN:=$(patsubst %,%-dirclean,$(TARGETS))\n \n@@ -429,11 +425,16 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(BR2_CONFIG)\n \n prepare: $(BUILD_DIR)/buildroot-config/auto.conf\n \n-world: $(TARGETS)\n+# Add base dependencies to all targets even on those not based on the\n+# package framework.\n+$(TARGETS): dirs prepare dependencies\n+\n+world: target-post-image\n \n .PHONY: all world toolchain dirs clean distclean source outputmakefile \\\n \tlegal-info legal-info-prepare legal-info-clean printvars \\\n-\t$(BASE_TARGETS) $(TARGETS) \\\n+\ttarget-finalize target-post-image \\\n+\t$(BASE_TARGETS) $(TARGETS) $(TARGETS_ROOTFS) \\\n \t$(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \\\n \t$(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \\\n \t$(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)\n@@ -493,7 +494,7 @@ endif\n STRIP_FIND_CMD += -type f \\( -perm /111 -o -name '*.so*' \\)\n STRIP_FIND_CMD += -not \\( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \\) -print\n \n-target-finalize:\n+target-finalize: $(TARGETS)\n \trm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \\\n \t\t$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \\\n \t\t$(TARGET_DIR)/usr/lib/cmake $(TARGET_DIR)/usr/share/cmake\n@@ -520,6 +521,8 @@ endif\n \t\tfind $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \\\n \t\txargs -r $(KSTRIPCMD); fi\n \n+$(TARGETS_ROOTFS): target-finalize\n+\n # See http://sourceware.org/gdb/wiki/FAQ, \"GDB does not see any threads\n # besides the one in which crash occurred; or SIGTRAP kills my program when\n # I set a breakpoint\"\n@@ -598,7 +601,7 @@ target-generatelocales: host-localedef\n \tdone\n endif\n \n-target-post-image:\n+target-post-image: $(TARGETS_ROOTFS)\n \t@$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \\\n \t\t$(call MESSAGE,\"Executing post-image script $(s)\"); \\\n \t\t$(USER_HOOKS_EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))\n@@ -635,7 +638,7 @@ legal-info: dirs legal-info-clean legal-info-prepare $(TARGETS_LEGAL_INFO) \\\n \t@rm -f $(LEGAL_WARNINGS)\n \n show-targets:\n-\t@echo $(TARGETS)\n+\t@echo $(TARGETS) $(TARGETS_ROOTFS)\n \n graph-build: $(O)/build/build-time.log\n \t@install -d $(O)/graphs\ndiff --git a/fs/common.mk b/fs/common.mk\nindex 30e7524..d95c26b 100644\n--- a/fs/common.mk\n+++ b/fs/common.mk\n@@ -64,7 +64,7 @@ ROOTFS_$(2)_COMPRESS_EXT = .xz\n ROOTFS_$(2)_COMPRESS_CMD = $$(XZ) -9 -C crc32 -c\n endif\n \n-$$(BINARIES_DIR)/rootfs.$(1): $$(ROOTFS_$(2)_DEPENDENCIES)\n+$$(BINARIES_DIR)/rootfs.$(1): target-finalize $$(ROOTFS_$(2)_DEPENDENCIES)\n \t@$$(call MESSAGE,\"Generating root filesystem image rootfs.$(1)\")\n \t$$(foreach hook,$$(ROOTFS_$(2)_PRE_GEN_HOOKS),$$(call $$(hook))$$(sep))\n \trm -f $$(FAKEROOT_SCRIPT)\n@@ -95,7 +95,7 @@ rootfs-$(1)-show-depends:\n rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1) $$(ROOTFS_$(2)_POST_TARGETS)\n \n ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)\n-TARGETS += rootfs-$(1)\n+TARGETS_ROOTFS += rootfs-$(1)\n endif\n endef\n \n", "prefixes": [ "v13", "4/7" ] }