Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/284073/?format=api
{ "id": 284073, "url": "http://patchwork.ozlabs.org/api/patches/284073/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1381982022-19291-6-git-send-email-rusty@rustcorp.com.au/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1381982022-19291-6-git-send-email-rusty@rustcorp.com.au>", "list_archive_url": null, "date": "2013-10-17T03:53:40", "name": "[5/7] hw/block/virtio-blk: use virtio wrappers to access headers.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "82d8d243ebd72fb8c2d7e29b495ede0ef5a925b3", "submitter": { "id": 553, "url": "http://patchwork.ozlabs.org/api/people/553/?format=api", "name": "Rusty Russell", "email": "rusty@rustcorp.com.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1381982022-19291-6-git-send-email-rusty@rustcorp.com.au/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/284073/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/284073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id B2E7B2C008C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 17 Oct 2013 14:59:38 +1100 (EST)", "from localhost ([::1]:50208 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1VWekK-0007d2-Ts\n\tfor incoming@patchwork.ozlabs.org; Wed, 16 Oct 2013 23:59:36 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:59654)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <rusty@ozlabs.org>) id 1VWejk-0007am-GX\n\tfor qemu-devel@nongnu.org; Wed, 16 Oct 2013 23:59:01 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <rusty@ozlabs.org>) id 1VWeji-0001F6-Q9\n\tfor qemu-devel@nongnu.org; Wed, 16 Oct 2013 23:59:00 -0400", "from ozlabs.org ([2402:b800:7003:1:1::1]:40530)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <rusty@ozlabs.org>) id 1VWeji-0001Eg-4y\n\tfor qemu-devel@nongnu.org; Wed, 16 Oct 2013 23:58:58 -0400", "by ozlabs.org (Postfix, from userid 1011)\n\tid D6B732C00D1; Thu, 17 Oct 2013 14:58:50 +1100 (EST)" ], "From": "Rusty Russell <rusty@rustcorp.com.au>", "To": "\"Marc Zyngier\" <marc.zyngier@arm.com>,\n\tqemu-devel@nongnu.org", "Date": "Thu, 17 Oct 2013 14:23:40 +1030", "Message-Id": "<1381982022-19291-6-git-send-email-rusty@rustcorp.com.au>", "X-Mailer": "git-send-email 1.8.1.2", "In-Reply-To": "<1381982022-19291-1-git-send-email-rusty@rustcorp.com.au>", "References": "<1381982022-19291-1-git-send-email-rusty@rustcorp.com.au>", "X-detected-operating-system": "by eggs.gnu.org: Error: Malformed IPv6 address\n\t(bad octet value).", "X-Received-From": "2402:b800:7003:1:1::1", "Cc": "Rusty Russell <rusty@rustcorp.com.au>", "Subject": "[Qemu-devel] [PATCH 5/7] hw/block/virtio-blk: use virtio wrappers\n\tto access headers.", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.14", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>\nReviewed-by: Anthony Liguori <aliguori@us.ibm.com>\n---\n hw/block/virtio-blk.c | 35 ++++++++++++++++++-----------------\n 1 file changed, 18 insertions(+), 17 deletions(-)", "diff": "diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c\nindex 49a23c3..111ad4b 100644\n--- a/hw/block/virtio-blk.c\n+++ b/hw/block/virtio-blk.c\n@@ -26,6 +26,7 @@\n # include <scsi/sg.h>\n #endif\n #include \"hw/virtio/virtio-bus.h\"\n+#include \"hw/virtio/virtio-access.h\"\n \n typedef struct VirtIOBlockReq\n {\n@@ -77,7 +78,7 @@ static void virtio_blk_rw_complete(void *opaque, int ret)\n trace_virtio_blk_rw_complete(req, ret);\n \n if (ret) {\n- bool is_read = !(ldl_p(&req->out->type) & VIRTIO_BLK_T_OUT);\n+ bool is_read = !(virtio_ldl_p(&req->out->type) & VIRTIO_BLK_T_OUT);\n if (virtio_blk_handle_rw_error(req, -ret, is_read))\n return;\n }\n@@ -224,12 +225,12 @@ static void virtio_blk_handle_scsi(VirtIOBlockReq *req)\n hdr.status = CHECK_CONDITION;\n }\n \n- stl_p(&req->scsi->errors,\n- hdr.status | (hdr.msg_status << 8) |\n- (hdr.host_status << 16) | (hdr.driver_status << 24));\n- stl_p(&req->scsi->residual, hdr.resid);\n- stl_p(&req->scsi->sense_len, hdr.sb_len_wr);\n- stl_p(&req->scsi->data_len, hdr.dxfer_len);\n+ virtio_stl_p(&req->scsi->errors,\n+ hdr.status | (hdr.msg_status << 8) |\n+ (hdr.host_status << 16) | (hdr.driver_status << 24));\n+ virtio_stl_p(&req->scsi->residual, hdr.resid);\n+ virtio_stl_p(&req->scsi->sense_len, hdr.sb_len_wr);\n+ virtio_stl_p(&req->scsi->data_len, hdr.dxfer_len);\n \n virtio_blk_req_complete(req, status);\n g_free(req);\n@@ -240,7 +241,7 @@ static void virtio_blk_handle_scsi(VirtIOBlockReq *req)\n \n fail:\n /* Just put anything nonzero so that the ioctl fails in the guest. */\n- stl_p(&req->scsi->errors, 255);\n+ virtio_stl_p(&req->scsi->errors, 255);\n virtio_blk_req_complete(req, status);\n g_free(req);\n }\n@@ -286,7 +287,7 @@ static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb)\n BlockRequest *blkreq;\n uint64_t sector;\n \n- sector = ldq_p(&req->out->sector);\n+ sector = virtio_ldq_p(&req->out->sector);\n \n bdrv_acct_start(req->dev->bs, &req->acct, req->qiov.size, BDRV_ACCT_WRITE);\n \n@@ -320,7 +321,7 @@ static void virtio_blk_handle_read(VirtIOBlockReq *req)\n {\n uint64_t sector;\n \n- sector = ldq_p(&req->out->sector);\n+ sector = virtio_ldq_p(&req->out->sector);\n \n bdrv_acct_start(req->dev->bs, &req->acct, req->qiov.size, BDRV_ACCT_READ);\n \n@@ -358,7 +359,7 @@ static void virtio_blk_handle_request(VirtIOBlockReq *req,\n req->out = (void *)req->elem.out_sg[0].iov_base;\n req->in = (void *)req->elem.in_sg[req->elem.in_num - 1].iov_base;\n \n- type = ldl_p(&req->out->type);\n+ type = virtio_ldl_p(&req->out->type);\n \n if (type & VIRTIO_BLK_T_FLUSH) {\n virtio_blk_handle_flush(req, mrb);\n@@ -487,12 +488,12 @@ static void virtio_blk_update_config(VirtIODevice *vdev, uint8_t *config)\n \n bdrv_get_geometry(s->bs, &capacity);\n memset(&blkcfg, 0, sizeof(blkcfg));\n- stq_raw(&blkcfg.capacity, capacity);\n- stl_raw(&blkcfg.seg_max, 128 - 2);\n- stw_raw(&blkcfg.cylinders, s->conf->cyls);\n- stl_raw(&blkcfg.blk_size, blk_size);\n- stw_raw(&blkcfg.min_io_size, s->conf->min_io_size / blk_size);\n- stw_raw(&blkcfg.opt_io_size, s->conf->opt_io_size / blk_size);\n+ virtio_stq_p(&blkcfg.capacity, capacity);\n+ virtio_stl_p(&blkcfg.seg_max, 128 - 2);\n+ virtio_stw_p(&blkcfg.cylinders, s->conf->cyls);\n+ virtio_stl_p(&blkcfg.blk_size, blk_size);\n+ virtio_stw_p(&blkcfg.min_io_size, s->conf->min_io_size / blk_size);\n+ virtio_stw_p(&blkcfg.opt_io_size, s->conf->opt_io_size / blk_size);\n blkcfg.heads = s->conf->heads;\n /*\n * We must ensure that the block device capacity is a multiple of\n", "prefixes": [ "5/7" ] }