Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/271/?format=api
{ "id": 271, "url": "http://patchwork.ozlabs.org/api/patches/271/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/48CB5E9A.4010000@gmail.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<48CB5E9A.4010000@gmail.com>", "list_archive_url": null, "date": "2008-09-13T06:32:58", "name": "physmap.c: Check return of platform_device_register()", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "eb411e47dbb144cb361891f1236722dbf2290469", "submitter": { "id": 35, "url": "http://patchwork.ozlabs.org/api/people/35/?format=api", "name": "Zev Weiss", "email": "zevweiss@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/48CB5E9A.4010000@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/271/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org>", "X-Original-To": "patchwork@ozlabs.org", "Delivered-To": "patchwork@ozlabs.org", "Received": [ "from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 376FADDDFD\n\tfor <patchwork@ozlabs.org>; Sat, 13 Sep 2008 16:33:40 +1000 (EST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeOgz-0002Ps-9i; Sat, 13 Sep 2008 06:33:13 +0000", "from wf-out-1314.google.com ([209.85.200.174])\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeOgo-0000nZ-I1\n\tfor linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 06:33:06 +0000", "by wf-out-1314.google.com with SMTP id 28so1126154wfc.24\n\tfor <linux-mtd@lists.infradead.org>;\n\tFri, 12 Sep 2008 23:33:01 -0700 (PDT)", "by 10.142.14.18 with SMTP id 18mr1779882wfn.129.1221287581724;\n\tFri, 12 Sep 2008 23:33:01 -0700 (PDT)", "from ?192.168.1.2? ( [24.84.185.161])\n\tby mx.google.com with ESMTPS id 30sm17091168wfg.9.2008.09.12.23.33.00\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tFri, 12 Sep 2008 23:33:00 -0700 (PDT)" ], "Message-ID": "<48CB5E9A.4010000@gmail.com>", "Date": "Fri, 12 Sep 2008 23:32:58 -0700", "From": "Zev Weiss <zevweiss@gmail.com>", "User-Agent": "Thunderbird 2.0.0.16 (X11/20080723)", "MIME-Version": "1.0", "To": "linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org", "Subject": "[PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()", "X-Spam-Score": "0.0 (/)", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.9", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linux-mtd-bounces@lists.infradead.org", "Errors-To": "linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org" }, "content": "The PHYSMAP_COMPAT code had been ignoring the return value of\nplatform_device_register() in the physmap_init() function.\n\nSigned-off-by: Zev Weiss <zevweiss@gmail.com>", "diff": "diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\nindex 42d844f..6fba0d4 100644\n--- a/drivers/mtd/maps/physmap.c\n+++ b/drivers/mtd/maps/physmap.c\n@@ -312,7 +312,7 @@ static int __init physmap_init(void)\n \terr = platform_driver_register(&physmap_flash_driver);\n #ifdef PHYSMAP_COMPAT\n \tif (err == 0)\n-\t\tplatform_device_register(&physmap_flash);\n+\t\terr = platform_device_register(&physmap_flash);\n #endif\n\n \treturn err;\n", "prefixes": [] }